IIRC, this happened once already, in the past: bubulle@sesostris:~/src/debian/samba/svn/trunk/samba$ ls -l ../../../samba-3.5.6/docs/manpages/smb.conf.5 -rw-r--r-- 1 bubulle bubulle 371037 18 juin 2010 ../../../samba-3.5.6/docs/manpages/smb.conf.5 bubulle@sesostris:~/src/debian/samba/svn/trunk/samba$ ls -l ../../../samba-3.5.8/docs/manpages/smb.conf.5 -rw-r--r-- 1 bubulle bubulle 27249 6 mars 19:50 ../../../samba-3.5.8/docs/manpages/smb.conf.5
*** Bug 8029 has been marked as a duplicate of this bug. ***
Michael (obnox) seems to have nailed down the problem, when building docs we seem to have difficulties in checking timestamps of smb.conf.xml and the parameters folder. At least for fedora there is an updated package though. Michael: is there a way to fix this properly upstream ?
Created attachment 6376 [details] patch for master Yes, the attached patch fixes the problem (for me). The commit message also explains the problem more thoroughly. I am about to push this to master. Cheers - Michael
can this be closed as resolved then ?
Before beging closed, shouldn't this be pushed to 3.5? Published 3.5.8 still has the problem. Assign to Karolin?
The 3.5.9 tarball is good. But the patch has not been applied. Broken manpages can be reproduced by doing "touch docs-xml/manpages-3/smb.conf.5.xml" prior to a build from a clean docs tree. The attached patch reliably fixes it for me.
Comment on attachment 6376 [details] patch for master Patch applies cleanly to v3-5-test.
==> gd for review and please assign to Karo if patch is appropriate.
Comment on attachment 6376 [details] patch for master looks good
Karolin, please add to v3-5-test for the next 3.5.x update.
*** Bug 7990 has been marked as a duplicate of this bug. ***
*** Bug 7991 has been marked as a duplicate of this bug. ***
Strange, in bug #7991, I added another patch that fixed the issue for me. That's a completely different approach. I pushed Michael's fix now, but I would like Jelmer (or anyone else) to comment on the the patch: https://attachments.samba.org/attachment.cgi?id=6579, please see https://bugzilla.samba.org/show_bug.cgi?id=7991 for details).
(In reply to comment #13) > Strange, in bug #7991, I added another patch that fixed the issue for me. > That's a completely different approach. > I pushed Michael's fix now, but I would like Jelmer (or anyone else) to comment > on the the patch: > https://attachments.samba.org/attachment.cgi?id=6579, please see > https://bugzilla.samba.org/show_bug.cgi?id=7991 for details). Well, this must have been coincidence (or rather a combination of changed time stamps of files). The patch should have no reliable influence on the correct generation of the parameter descriptions: As I wrote in comment #6, simply touching the smb.conf.5.xml file in a fresh checkout lets the docs build create the same incomplete manpage as before. Creating a phony parameters target fixes this reliably. Thanks for pushing the patch. Cheers - Michael
Closing out bug report.