The Samba-Bugzilla – Bug 2137
SWAT mangles names with containing spaces
Last modified: 2005-08-24 10:16:35 UTC
when using space in group name and using those groups for entry like "admin
users" or "printer admin users", swat change the string like that :
so I enter my configuration like this :
admin users = @"Admins du domaine"
after a change with swat, it changes it like this :
admin users = '@Admins du domaine'
after another modification with swat, it changes it again like this :
admin users = '@Admins, du, domaine'
after the last modification, configuration file is false. So samba does not
recognize "admin users", and i can't no more administrate my domain !
I use space, because I import groups and users from an existing domain.
This was fixed a couple of release ago. Should be fine in 3.0.9.
Stick with double quotes.
(In reply to comment #1)
> This was fixed a couple of release ago. Should be fine in 3.0.9.
> Stick with double quotes.
Sorry I don't agree with you !
I just test 3.0.9 on redhat 3 update 3, and the problem is ever present !
The problem is present in release 3.0.10 too.
*** Bug 2084 has been marked as a duplicate of this bug. ***
*** Bug 1908 has been marked as a duplicate of this bug. ***
Created attachment 1004 [details]
Patch to swat to have it use the correct quote characters.
I whipped this up last night. Unfortunatly, looking at the code convinces me
that SWAT has a few more quoting issues. Fixing them will take a longer patch.
Created attachment 1007 [details]
This patch includes the terminating ';' characters on ", and correctly
quotes other HTML metacharacters when they appear in paramaters.
I applied the first patch from Jay Fenlason to correct the quoting problems.
This works fine now. I didn't apply the second patch as it was larger and not
really necessary for this problem.
sorry for the same, cleaning up the database to prevent unecessary reopens of bugs.