Bug 9796 - libsmbclient does not accept non-standard port.
Summary: libsmbclient does not accept non-standard port.
Status: ASSIGNED
Alias: None
Product: Samba 3.6
Classification: Unclassified
Component: libsmbclient (show other bugs)
Version: 3.6.6
Hardware: All All
: P5 normal
Target Milestone: ---
Assignee: Jeremy Allison
QA Contact: Samba QA Contact
URL: https://bugzilla.gnome.org/show_bug.c...
Keywords:
: 9452 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-04-15 18:38 UTC by Leonardo Amaral
Modified: 2013-09-25 16:02 UTC (History)
1 user (show)

See Also:

Attachments
git-am fix for master. (34.01 KB, patch)
2013-04-18 21:12 UTC, Jeremy Allison 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Leonardo Amaral 2013-04-15 18:38:07 UTC 
As described in https://bugzilla.gnome.org/show_bug.cgi?id=698071 libsmbclient is the responsable to do not accept non-standard port in smb connections.
Comment 1 Jeremy Allison 2013-04-15 22:53:02 UTC 
Ok, what I want it the gvfs developers to tell me exactly what interface you want for this in libsmbclient.

I'm thinking of 2 extra calls:

uint16_t smbc_getPort(SMBCCTX *c)
void smbc_setPort(SMBCCTX *c, uint16_t port);

Does that work for you ?

Jeremy.
Comment 2 Jeremy Allison 2013-04-16 17:25:10 UTC 
*** Bug 9452 has been marked as a duplicate of this bug. ***
Comment 3 Jeremy Allison 2013-04-18 00:17:34 UTC 
Ok, I have a patch implementing this. Compiles but not yet tested. I'll upload for 4.0.x and 3.6.x once I've confirmed it works.

Jeremy.
Comment 4 Jeremy Allison 2013-04-18 21:12:55 UTC 
Created attachment 8787 [details]
git-am fix for master.

Note - this is a master only (4.1.x) patch. For 4.0.x I will remove the new smbc_getPort() smbc_setPort() calls and the ABI bump, leaving that url parsing code as the only way to get the port info for 4.0.x and 3.6.x.

Please test (works for me).

Jeremy.
Comment 5 Jeremy Allison 2013-04-26 22:02:15 UTC 
Ping - can you let me know if this fix works for you ? It works in my testing.

Not getting feedback from you is preventing me from getting this into master.

Jeremy.
Comment 6 Jeremy Allison 2013-06-11 20:52:37 UTC 
Gnome developers have confirmed this works. Fix has gone into master. Now, should we leave this as a 4.1.x only fix, or back-port ?

Jeremy.
Comment 7 Jérémy Bethmont 2013-09-25 15:58:58 UTC 
Could you backport it please? Samba 3.6.x is still the default version on Ubuntu.
Comment 8 Jeremy Allison 2013-09-25 16:02:19 UTC 
I don't think we (the Samba Team) will back-port, as 3.6.x is about to go into maintanence-only mode. I'm willing to review any Ubuntu-specific backport you might want to do, but it's not going to go into the samba.org tree. We might back-port to 4.0.x.

Jeremy.