The Samba-Bugzilla – Bug 9796
libsmbclient does not accept non-standard port.
Last modified: 2013-09-25 16:02:19 UTC
As described in https://bugzilla.gnome.org/show_bug.cgi?id=698071 libsmbclient is the responsable to do not accept non-standard port in smb connections.
Ok, what I want it the gvfs developers to tell me exactly what interface you want for this in libsmbclient.
I'm thinking of 2 extra calls:
uint16_t smbc_getPort(SMBCCTX *c)
void smbc_setPort(SMBCCTX *c, uint16_t port);
Does that work for you ?
*** Bug 9452 has been marked as a duplicate of this bug. ***
Ok, I have a patch implementing this. Compiles but not yet tested. I'll upload for 4.0.x and 3.6.x once I've confirmed it works.
Created attachment 8787 [details]
git-am fix for master.
Note - this is a master only (4.1.x) patch. For 4.0.x I will remove the new smbc_getPort() smbc_setPort() calls and the ABI bump, leaving that url parsing code as the only way to get the port info for 4.0.x and 3.6.x.
Please test (works for me).
Ping - can you let me know if this fix works for you ? It works in my testing.
Not getting feedback from you is preventing me from getting this into master.
Gnome developers have confirmed this works. Fix has gone into master. Now, should we leave this as a 4.1.x only fix, or back-port ?
Could you backport it please? Samba 3.6.x is still the default version on Ubuntu.
I don't think we (the Samba Team) will back-port, as 3.6.x is about to go into maintanence-only mode. I'm willing to review any Ubuntu-specific backport you might want to do, but it's not going to go into the samba.org tree. We might back-port to 4.0.x.