Bug 9456 - developer-build: panic when acl_xattr fails with access denied
Summary: developer-build: panic when acl_xattr fails with access denied
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.0
Classification: Unclassified
Component: File services (show other bugs)
Version: 4.0.0rc5
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks: 8622
  Show dependency tree / graph
 
Reported: 2012-12-04 10:37 UTC by Michael Adam
Modified: 2012-12-05 07:54 UTC (History)
2 users (show)

See Also:

Attachments
patch for v4-0-test (1.31 KB, patch)
2012-12-04 10:40 UTC, Michael Adam 		obnox: review+
metze: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Adam 2012-12-04 10:37:51 UTC 
In the --developer build, there is a panic due to talloc stack frames not freed in order when setting an acl via the acl_xattr module (or acl_tdb) fails with ACCESS_DENIED.

One way to reproduce:

- configure.developer ...
- build without posix acl support (I did it by accident)
- configure a share with vfs_acl_xattr enabled (vfs objects = acl_xattr)
- crate a file in that share
- add an ace to the acl of the file
  => this failed with access denied due to "to many aces to map to posix perms"
  => error code path in vfs_acl_common does not free frame
  => main event loop panics "frame not freed in order"

This is a panic only in developer builds.

Michael
Comment 1 Michael Adam 2012-12-04 10:40:28 UTC 
Created attachment 8273 [details]
patch for v4-0-test

Patch as cherry-picked from master
Comment 2 Stefan Metzmacher 2012-12-04 10:43:39 UTC 
Comment on attachment 8273 [details]
patch for v4-0-test

Looks good
Comment 3 Karolin Seeger 2012-12-04 10:49:25 UTC 
Pushed to autobuild-v4-0-test.
Comment 4 Karolin Seeger 2012-12-05 07:54:27 UTC 
Pushed to v4-0-test.
Closing out bug report.

Thanks!