Bug 9399 - 'samba-tool dns serverinfo localhost' returns 'Memory allocation error'
Summary: 'samba-tool dns serverinfo localhost' returns 'Memory allocation error'
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.0
Classification: Unclassified
Component: Tools (show other bugs)
Version: 4.0.0rc5
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-15 08:20 UTC by Karolin Seeger
Modified: 2012-12-03 19:25 UTC (History)
4 users (show)

See Also:

Attachments
Untested patch (922 bytes, patch)
2012-11-15 09:14 UTC, Kai Blin 		no flags Details
Updated and tested patch as cherry-picked from master. (1.36 KB, patch)
2012-12-03 12:07 UTC, Michael Adam 		kseeger: review+
obnox: review+
Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Karolin Seeger 2012-11-15 08:20:55 UTC 
'samba-tool dns serverinfo localhost' does not work and returns 'Memory allocation error'.

Please note that 'samba-tool dns serverinfo 127.0.0.1' and 'samba-tool dns serverinfo $HOST' work fine.
Comment 1 Karolin Seeger 2012-11-15 08:22:02 UTC 
Re-assigning to Kai as he is working on this one.
Adding Jelmer and me to the CC list.
Comment 2 Kai Blin 2012-11-15 08:49:19 UTC 
Still looking into this, as the patch proposed on samba-technical isn't optimal.
Comment 3 Kai Blin 2012-11-15 09:14:22 UTC 
Created attachment 8199 [details]
Untested patch

Following Rowland Penny's note on the samba-technical mailing list, it's only 'localhost' that is broken.
Comment 4 Karolin Seeger 2012-11-15 10:38:55 UTC 
(In reply to comment #3)
> Created attachment 8199 [details]
> Untested patch
> 
> Following Rowland Penny's note on the samba-technical mailing list, it's only
> 'localhost' that is broken.

With this patch, 'samba-tool dns serverinfo localhost' works fine.
Kai, thanks a lot for investigating!
Comment 5 Jelmer Vernooij 2012-11-15 11:54:35 UTC 
It's a bit of a hack though, unfortunately. What about aliases for localhost, e.g. localhost-ip6?
Comment 6 Kai Blin 2012-11-15 12:42:47 UTC 
Not more of a hack than the other version I sent to samba-technical recently. Even less, I'd argue.
Comment 7 Michael Adam 2012-12-03 12:07:42 UTC 
Created attachment 8265 [details]
Updated and tested patch as cherry-picked from master.
Comment 8 Michael Adam 2012-12-03 12:08:00 UTC 
Comment on attachment 8265 [details]
Updated and tested patch as cherry-picked from master.

ACK
Comment 9 Michael Adam 2012-12-03 12:08:48 UTC 
==> Karolin for review and picking to 4.0
Comment 10 Karolin Seeger 2012-12-03 19:25:33 UTC 
Pushed to v4-0-test.
Closing out bug report.

Thanks!