From 32794c8d81d5136361376bcacbe7b75962b4741d Mon Sep 17 00:00:00 2001 From: Kai Blin Date: Wed, 14 Nov 2012 11:32:06 +0100 Subject: [PATCH] samba-tool dns: Don't use "localhost" to connect to local host Calling "samba-tool dns localhost" provokes a stacktrace. This just makes 'samba-tool dns localhost' work and doesn't fix the underlying issue, but I don't see it causing any harm (unless you don't have an ipv4 localhost, I guess). Signed-off-by: Kai Blin Reviewed-by: Michael Adam Autobuild-User(master): Michael Adam Autobuild-Date(master): Fri Nov 16 13:18:14 CET 2012 on sn-devel-104 (cherry picked from commit 10b6cceb1f0f09c7a8f5fc8882fdc3852d11951f) --- source4/scripting/python/samba/netcmd/dns.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/source4/scripting/python/samba/netcmd/dns.py b/source4/scripting/python/samba/netcmd/dns.py index 8bd3249..c00d17a 100644 --- a/source4/scripting/python/samba/netcmd/dns.py +++ b/source4/scripting/python/samba/netcmd/dns.py @@ -31,6 +31,8 @@ from samba.dcerpc import dnsp, dnsserver def dns_connect(server, lp, creds): + if server.lower() == 'localhost': + server = '127.0.0.1' binding_str = "ncacn_ip_tcp:%s[sign]" % server dns_conn = dnsserver.dnsserver(binding_str, lp, creds) return dns_conn -- 1.7.9.5