Bug 9381 - ACLs set on directories with 'samba-tool' would not stick
Summary: ACLs set on directories with 'samba-tool' would not stick
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.0
Classification: Unclassified
Component: AD: LDB/DSDB/SAMDB (show other bugs)
Version: 4.0.0rc4
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Andrew Bartlett
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on: 9406
Blocks: 8622 9342
  Show dependency tree / graph
 
Reported: 2012-11-12 09:06 UTC by Andrew Bartlett
Modified: 2012-12-04 11:03 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Bartlett 2012-11-12 09:06:24 UTC 
Due to a mix-up with the fsp->is_directory flag, ACLs set on directories would not stick, and so would cause 'samba-tool ntacl sysvolcheck' to fail.

The failure was odd, as the ACL would just revert back to the mapping of the underlying posix ACL, and the hash wouldn't match.  Investigation showed some ACEs are only added for directory ACLs.

Patches are on samba-technical awaiting comment.
Comment 1 Andrew Bartlett 2012-11-19 23:17:03 UTC 
Fixes for this are in master, and in the mega-patch in bug #9406 for 4.0.
Comment 2 Karolin Seeger 2012-12-04 11:03:42 UTC 
Should be fixed in Samba 4.0.0rc6.
Please feel free to re-open if it's still an issue.

Thanks!