We install libnss_winbind.so.2 but don't create the needed symlink libnss_winbind.so -> libnss_winbind.so.2 during installation. So all distributions do that in the build file.
Created attachment 8086 [details] v4-0-test patch
Comment on attachment 8086 [details] v4-0-test patch Reviewed-by: David Disseldorp <ddiss@samba.org>
Karolin, can you please push to master and v4-0-test. Thanks.
Pushed to master, waiting for autobuild. Please note that I would prefer the reviewer to push the patches to master. Thanks!
Karolin, I think you can cherry-pick the patches from master to v4-0-test
The second patch does not apply to current v4-0-test branch. Re-assigning to Andreas to provide a patch for v4-0-test. Thanks!
Created attachment 8112 [details] v4-0-test patch
Pushed to autobuild-v4-0-test. Closing out bug report. Thanks!
Comment on attachment 8112 [details] v4-0-test patch This conflicts with some other changes under nsswitch/.
Created attachment 8113 [details] Complete backport of nsswitch/ changes from master I think there's currently no reason why nsswitch/ should differ between v4-0-test and master. So we better backport changes in the same order, so that git cherry-pick -x works without conflicts.
Comment on attachment 8113 [details] Complete backport of nsswitch/ changes from master Most of this will be fixed as part of bug 9339
Andreas Schneider wrote: > We install libnss_winbind.so.2 but don't create the needed symlink > libnss_winbind.so -> libnss_winbind.so.2 during installation. So all > distributions do that in the build file. In Debian/Ubuntu we don't, so this change means those distributions now need to start removing these .so files in the packaging.
So, where are we at with this? Do we need to sort out anything more for 4.0 (and add a blocker?)
Why do you have to remove them. Does it hurt packaging them?
does anybody know why Debian does look for the .so.2 lib while other distributions look for the .so lib only? We should also clarify why the dists use the 2 version and when this number changes so that we can adopt our symlinking to that. It wouldn't make much sense to make a dumb .2 symlink while this might change to .3 with future glibc versions.
(In reply to comment #15) > does anybody know why Debian does look for the .so.2 lib while other > distributions look for the .so lib only? I mean the other way round...
The fix (commit 1f017efeedffed84b872bd17ebefee7dfff0d11a) for this bug, introduces a regression, it changes the soname of the library, this should be libnss_winbind.so.2 and is just libnss_winbind.so now.
Created attachment 10548 [details] Patches for master
Created attachment 10560 [details] Patches for v4-2-test
Created attachment 10561 [details] Patches for v4-1-test
Created attachment 10562 [details] Patches for v4-0-test
Comment on attachment 10562 [details] Patches for v4-0-test LGTM
Karolin, please add the patches to the relevant branches. Thanks!
(In reply to Andreas Schneider from comment #23) Pushed to autobuild-v4-[0|1|2]-test.
Created attachment 10588 [details] Patches for v4-1-test Fixed patch without adding abs_path().
Created attachment 10589 [details] Patches for v4-0-test Fixed patch without adding abs_path().
Karolin, please take the new 4.0 and 4.1 patches, they should pass autobuild now...
(In reply to Stefan (metze) Metzmacher from comment #27) Pushed to autobuild-v4-[0|1|2]-test.
(In reply to Karolin Seeger from comment #28) autobuild-v4-2-test still fails, re-trying without these patches. Pushed to v4-0-test and v4-1-test.
(In reply to Karolin Seeger from comment #29) Still failing without these patches. Starting further investigation now.
Sorry, I have to withdraw my patch review. commit 575b093dac3c509b1bfaab0b4ad29b9b4214e487 Author: Stefan Metzmacher <metze@samba.org> AuthorDate: Thu Dec 18 10:33:34 2014 +0100 Commit: Stefan Metzmacher <metze@samba.org> CommitDate: Fri Dec 19 13:15:12 2014 +0100 nsswitch: fix soname of linux nss_*.so.2 modules Bug: https://bugzilla.samba.org/show_bug.cgi?id=9299 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Looks like this patch breaks linking Samba. In master try to build Samba with the following options: ./configure.developer --libdir=/usr/lib64 --enable-fhs --prefix=/usr --sbindir=/usr/sbin --localstatedir=/var --sysconfdir=/etc/samba --with-statedir=/var/lib/samba --with-configdir=/etc/samba --with-lockdir=/var/lib/samba --with-logfilebase=/var/log/samba --with-piddir=/run --with-privatedir=/etc/samba --with-pammodulesdir=/lib64/security --disable-rpath-install --enable-cups --disable-gnutls --bundled-libraries=heimdal,!zlib,!popt --with-shared-modules=vfs_cacheprime,vfs_readahead,idmap_ad,idmap_ldap,idmap_rid,pdb_tdbsam,pdb_ldapsam,pdb_ads,pdb_smbpasswd,pdb_wbc_sam,pdb_samba4,auth_netlogond,auth_samba4 --with-pam --without-pam_smbpass --without-fam --with-profiling-data --with-systemd make -j [4065/4316] Linking default/source3/winbindd/winbindd ../source3/rpc_server/rpc_ncacn_np.c:138: error: undefined reference to 'copy_session_info' ../source3/rpc_server/rpc_ncacn_np.c:219: error: undefined reference to 'copy_session_info' ../source3/rpc_server/rpc_ncacn_np.c:704: error: undefined reference to 'copy_session_info' ../source3/rpc_server/rpc_ncacn_np.c:845: error: undefined reference to 'copy_session_info' ../source3/rpc_server/srv_pipe.c:537: error: undefined reference to 'session_info_set_session_key' ../source3/rpc_server/rpc_server.c:1080: error: undefined reference to 'make_session_info_guest' ../source3/winbindd/winbindd.c:1268: error: undefined reference to 'netsamlogon_cache_init' ../source3/winbindd/winbindd.c:1654: error: undefined reference to 'init_system_session_info' ../source3/winbindd/winbindd_util.c:1058: error: undefined reference to 'netsamlogon_cache_get' ../source3/winbindd/winbindd_cache.c:2289: error: undefined reference to 'netsamlogon_cache_have' ../source3/winbindd/winbindd_cache.c:2429: error: undefined reference to 'netsamlogon_cache_have' ../source3/winbindd/winbindd_cache.c:3129: error: undefined reference to 'netsamlogon_clear_cached_user' ../source3/winbindd/winbindd_pam.c:323: error: undefined reference to 'add_aliases' ../source3/winbindd/winbindd_pam.c:325: error: undefined reference to 'add_aliases' ../source3/winbindd/winbindd_pam.c:338: error: undefined reference to 'nt_token_check_sid' ../source3/winbindd/winbindd_pam.c:1246: error: undefined reference to 'make_user_info' ../source3/winbindd/winbindd_pam.c:1263: error: undefined reference to 'make_auth_context_fixed' ../source3/winbindd/winbindd_pam.c:1271: error: undefined reference to 'auth_check_ntlm_password' ../source3/winbindd/winbindd_pam.c:1287: error: undefined reference to 'serverinfo_to_SamInfo3' ../source3/winbindd/winbindd_pam.c:1823: error: undefined reference to 'netsamlogon_cache_get' ../source3/winbindd/winbindd_pam.c:1842: error: undefined reference to 'netsamlogon_cache_store' ../source3/winbindd/winbindd_pam.c:1985: error: undefined reference to 'netsamlogon_cache_get' ../source3/winbindd/winbindd_pam.c:2004: error: undefined reference to 'netsamlogon_cache_store' ../source3/winbindd/winbindd_pam.c:2552: error: undefined reference to 'create_info3_from_pac_logon_info' ../source3/winbindd/winbindd_pam.c:2558: error: undefined reference to 'netsamlogon_cache_store' ../source3/winbindd/winbindd_pam.c:2577: error: undefined reference to 'copy_netr_SamInfo3' ...
Hmm, patch is already included in 4.1.15. :-( Should I revert the patch in v4-0-test?
It is probably a combination of these patches which break it. I haven't had time to look for a fix yet. Better revert it if possible.
(In reply to Andreas Schneider from comment #31) commit 76fdcf5c15bd904c3686f0c2dd93d27486c61ca4 Author: Stefan Metzmacher <metze@samba.org> AuthorDate: Thu Dec 18 15:05:12 2014 +0100 Commit: Stefan Metzmacher <metze@samba.org> CommitDate: Fri Dec 19 13:15:12 2014 +0100 wafsamba: fill PRIVATE_NAME() logic again We append bld.env.PRIVATE_EXTENSION to the name of private libraries again, but only unless they have a abi_directory, vnum or soname defined. This avoids naming conflicts with system libraries, e.g. libidmap.so on Solaris Bug: https://bugzilla.samba.org/show_bug.cgi?id=10112 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Is the problem for Andreas, so this is not related to the patches in this bug report. The problem is that bin/default/source3/auth/libauth-samba4.so is being created two times. Once by SAMBA3_LIBRARY('auth',...) and once again by SAMBA3_MODULE('auth_samba4', ...). As a result bin/default/source3/auth/libauth-samba4.so gets randomly overwritten. I'll post fixes for this problem to samba-technical. Andreas please readd your review+ here, thanks!
Metze, Karolin reports in comment #30 that it fails for 4.2-test branch. This is pobably due to the PRIVATE_NAME patch revealing the library-with-the-same-name-issue.
Karolin, please pick the v4-2-test patch.
Pushed to autobuild-v4-2-test...
Pushed to v4-0-test, v4-1-test and v4-2-test. Closing out bug report. Thanks1