Bug 9178 - dmapi checks missing in waf
Summary: dmapi checks missing in waf
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.0
Classification: Unclassified
Component: Build (show other bugs)
Version: 4.0.0rc1
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks: 8622 8969
  Show dependency tree / graph
 
Reported: 2012-09-19 15:31 UTC by Christian Ambach
Modified: 2012-11-13 10:43 UTC (History)
1 user (show)

See Also:

Attachments
proposed patch (4.08 KB, patch)
2012-11-08 13:56 UTC, Christian Ambach 		no flags Details
patch that compiles on AIX 6.1 (4.90 KB, patch)
2012-11-09 18:15 UTC, Christian Ambach 		metze: review+
Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Ambach 2012-09-19 15:31:16 UTC 
You cannot build vfs_tsmsm (and other code relying on DMAPI) with the waf build because waf does not do checks that configure.in has
Comment 1 Andrew Bartlett 2012-10-18 07:16:45 UTC 
As you have access to a system with this, could you create a patch to check for dmapi?  It is the last major feature that I know of that we are missing tests for.
Comment 2 Karolin Seeger 2012-11-06 11:30:15 UTC 
Re-assigning to Christian.
Comment 3 Christian Ambach 2012-11-08 13:56:51 UTC 
Created attachment 8167 [details]
proposed patch

Proposed patch, tested to work with libdmapi from GPFS on Linux
Comment 4 Christian Ambach 2012-11-08 13:57:38 UTC 
Björn, could you help me and see if the patch successfully detects the libs on IRIX?
I'll try to get a hold on a AIX box for testing
Comment 5 Björn Jacke 2012-11-08 14:39:13 UTC 
the machine is soo slow. It looks like you copied the check logic from the autoconf checks, right? Just check it in and we'll see in the build farm the result after a day :-)
Comment 6 Christian Ambach 2012-11-08 17:25:38 UTC 
ok, fails on AIX 6.1 :(
Will do more fixing and testing
Comment 7 Christian Ambach 2012-11-09 18:15:47 UTC 
Created attachment 8176 [details]
patch that compiles on AIX 6.1

I'll put this patchset into master now to see how the buildfarm reacts
Comment 8 Christian Ambach 2012-11-12 14:45:26 UTC 
Buildfarm is happy about it
1. AIX 5 detects and compiles
2. IRIX detects and compiles
Comment 9 Stefan Metzmacher 2012-11-12 15:02:01 UTC 
Comment on attachment 8176 [details]
patch that compiles on AIX 6.1

Looks ok
Comment 10 Stefan Metzmacher 2012-11-12 15:03:05 UTC 
Karolin, please pick this to v4-0-test
Comment 11 Karolin Seeger 2012-11-13 08:50:12 UTC 
Pushed to autobuild-v4-0-test.
Comment 12 Karolin Seeger 2012-11-13 10:43:34 UTC 
Pushed to v4-0-test.
Closing out bug report.

Thanks!