With ntp signing enabled we experienced a SEGV of ntp_signd in source4/ntp_signd/ntp_signd.c:+194 gdb traceback and code show the following line as triggering the fault: ============================================================================ user_account_control = ldb_msg_find_attr_as_uint(res->msgs[0], "userAccountControl", 0); ============================================================================ (gdb) print res $1 = (struct ldb_result *) 0xa977930 (gdb) print res->msgs[0] Cannot access memory at address 0x0 (gdb) print res->msgs $2 = (struct ldb_message **) 0x0
Created attachment 7656 [details] Return on error seems to be missing a couple of lines earlier, see suggested patch.
Some context info: This code path probably is really rarely used, as the cause was a broken machine account object, which was lacking *any* object class at all and thus also the required attributes. May be caused by some rare replication issue, as it only occured on one (replicating) DC out of three (total). The patch fixes a possible segfault in this case anyway and the increased debug level really helped to track down the broken object efficiently.
any chance of getting this as a git format-patch? (very happy to apply it then)
Created attachment 7773 [details] git format-patch
Fixed with a74ca56c482257f79eb6f966fc490657a0d6407b