Bug 8863 - aio outstanding events and the counter for them can get out of sync.
Summary: aio outstanding events and the counter for them can get out of sync.
Status: NEW
Alias: None
Product: Samba 3.6
Classification: Unclassified
Component: File services (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal
Target Milestone: ---
Assignee: Volker Lendecke
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks: 8874
  Show dependency tree / graph
 
Reported: 2012-04-13 22:26 UTC by Jeremy Allison
Modified: 2012-04-18 16:22 UTC (History)
0 users

See Also:

Attachments
git-am patchset for 3.6.next. (19.97 KB, patch)
2012-04-13 22:35 UTC, Jeremy Allison 		vl: review-
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Allison 2012-04-13 22:26:43 UTC 
There have been several fixes in master to the aio subsystem that need to be back-ported to 3.6.next (IMHO) to improve aio stability. One is the lifecycle of the outstanding_aio_calls counter, another one is the initialization of 
aio_pending_size.

These are a mixture of Volker's changes and mine.

I'll attach a git-am back port for 3.6.next for Volker to review.

Jeremy.
Comment 1 Jeremy Allison 2012-04-13 22:35:30 UTC 
Created attachment 7453 [details]
git-am patchset for 3.6.next.

Volker please review and let me know if you think it's appropriate.
Jeremy.
Comment 2 Volker Lendecke 2012-04-18 06:09:08 UTC 
I think we should not do mass-porting of patches to 3.6. This is for master only I think. Nobody runs 3.6 on OS/X really, Apple have provided their own version of CIFS service. So it's a nice excercise to make AIO work on OS/X, but it is nothing for a production release. We have the next major release for that.
Comment 3 Volker Lendecke 2012-04-18 06:09:28 UTC 
Comment on attachment 7453 [details]
git-am patchset for 3.6.next.

See my comment in the bug.
Comment 4 Jeremy Allison 2012-04-18 16:22:19 UTC 
Ok, it's not essential to have these fixes. They mainly clean up the error paths (fyi, this is nothing to do with running Samba on OSX) and we can do without them until 4.0.

Jeremy.