Bug 8721 - only a subset of child directories load when vfs_dirsort is enabled
Summary: only a subset of child directories load when vfs_dirsort is enabled
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: VFS Modules (show other bugs)
Version: unspecified
Hardware: All All
: P5 critical (vote)
Target Milestone: ---
Assignee: Samba QA Contact
QA Contact: Samba QA Contact
URL:
Keywords:
: 6985 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-01-25 18:17 UTC by Jonathan
Modified: 2022-06-14 10:39 UTC (History)
4 users (show)

See Also:

Attachments
log file for mac os X lion client accessing samba share. debug level 6 (39 bytes, text/plain)
2012-01-25 18:53 UTC, Jonathan 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan 2012-01-25 18:17:06 UTC 
If and only if vfs_dirsort is enabled, Mac OS X line client will not load all child directories when more than 800 or so (guessing) child directories are present in a directory. This behavior is 100% consistent on Mac OS X Lion client.

This behavior also occurs in Windows XP and Windows 7 clients, however it is erratic. On windows, often a refresh will load the complete directory.

In the attached log file, I connect to the server from Mac OS X Lion client and navigate to a directory with > 2,000 child directories. Only about 300 or so load (files beginning with A-C) before the directory listing stops. 

Server is running Debian Wheezy. Linux fs4 3.1.0-1-amd64 #1 SMP Tue Jan 10 05:01:58 UTC 2012 x86_64 GNU/Linux
Comment 1 Jonathan 2012-01-25 18:53:21 UTC 
Created attachment 7254 [details]
log file for mac os X lion client accessing samba share. debug level 6
Comment 2 Jonathan 2012-01-25 20:30:28 UTC 
I marked this critical because if you try to copy one of these partially loaded directories, you will in fact only get a partial transfer, though on the windows end everything looks normal (unless you compare the size of what you "copied" to the size of the original).

So, data loss is a possibility on large directories with vfs_dirsort enabled.
Comment 3 Bug Reporter 2014-10-30 05:14:00 UTC 
Just wanted to point out that this is STILL an issue years and years later, and it's one that can absolutely result in data loss. If no one is going to contribute a fix, this plugin should be removed from the distribution completely. As is, it's a disaster waiting to happen to anyone who touches it.
Comment 4 Björn Jacke 2014-10-30 11:26:30 UTC 
*** Bug 6985 has been marked as a duplicate of this bug. ***
Comment 5 Jeremy Allison 2014-10-30 21:01:42 UTC 
The vfs_dirsort module got some recent updates. Try and reproduce using latest 4.1 and Windows. If you can reproducibly show the bug I'll take a look.

Thanks,

Jeremy.
Comment 6 Björn Jacke 2022-06-14 10:39:08 UTC 
closing as there are no more complaints here and it seems to work better these days.