Bug 6785 - Only ever handle one event after a select call
Summary: Only ever handle one event after a select call
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.4
Classification: Unclassified
Component: Winbind (show other bugs)
Version: 3.4.2
Hardware: Other All
: P3 normal
Target Milestone: ---
Assignee: Volker Lendecke
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-07 08:58 UTC by Volker Lendecke
Modified: 2009-10-08 05:28 UTC (History)
0 users

See Also:

Attachments
Patch for 3.4 (1.56 KB, patch)
2009-10-07 09:00 UTC, Volker Lendecke 		metze: review+
Details
Patch for 3.3 (1.56 KB, patch)
2009-10-07 09:01 UTC, Volker Lendecke 		metze: review+
Details
Patch for 3.3 (1.27 KB, patch)
2009-10-08 04:39 UTC, Volker Lendecke 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Volker Lendecke 2009-10-07 08:58:36 UTC 
I've just come across a winbind that was stuck in accept(priv-pipe). The only explanation I have is that we do too much between select and the fd event handlers. I think the attached patches need to go into 3.4 and 3.3

Volker
Comment 1 Volker Lendecke 2009-10-07 09:00:34 UTC 
Created attachment 4798 [details]
Patch for 3.4
Comment 2 Volker Lendecke 2009-10-07 09:01:45 UTC 
Created attachment 4799 [details]
Patch for 3.3
Comment 3 Stefan Metzmacher 2009-10-07 09:13:58 UTC 
Comment on attachment 4798 [details]
Patch for 3.4

looks good
Comment 4 Stefan Metzmacher 2009-10-07 09:14:22 UTC 
Comment on attachment 4799 [details]
Patch for 3.3

looks good
Comment 5 Volker Lendecke 2009-10-07 09:19:19 UTC 
Karolin, please merge to 3.3 and 3.4.

Thanks,

Volker
Comment 6 Karolin Seeger 2009-10-08 03:59:14 UTC 
Pushed to v3-4-test.
Patch for v3-3-test creates a merge conflict.
Comment 7 Volker Lendecke 2009-10-08 04:39:09 UTC 
Created attachment 4812 [details]
Patch for 3.3
Comment 8 Karolin Seeger 2009-10-08 05:28:36 UTC 
Thanks, Volker!
Pushed to v3-3-test, too.
Closing out bug report.