From a6c0ca5f03250e61d26b670321e9e9aa9f9545a4 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Wed, 7 Oct 2009 15:53:46 +0200 Subject: [PATCH] s3:winbind: Only ever handle one event after a select call While handling an fd event, the situation with other fds can change. I've just seen a winbind stuck in the accept() call on the privileged pipe. I can only imagine this happen because under high load we first handled other requests and meanwhile the client on the privileged pipe went away. --- source/winbindd/winbindd.c | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/source/winbindd/winbindd.c b/source/winbindd/winbindd.c index 9005e67..1d618e2 100644 --- a/source/winbindd/winbindd.c +++ b/source/winbindd/winbindd.c @@ -847,7 +847,9 @@ static void process_loop(void) message_dispatch(winbind_messaging_context()); - run_events(winbind_event_context(), 0, NULL, NULL); + if (run_events(winbind_event_context(), 0, NULL, NULL)) { + return; + } /* refresh the trusted domain cache */ @@ -927,8 +929,10 @@ static void process_loop(void) flags |= EVENT_FD_READ; if (FD_ISSET(ev->fd, &w_fds)) flags |= EVENT_FD_WRITE; - if (flags) + if (flags) { ev->handler(ev, flags); + return; + } ev = next; } -- 1.6.2.1