Do not work VFS full_audit Part of my smb.conf: [exchanger] vfs object = full_audit full_audit:prefix = %u|%I full_audit:failure = none full_audit:success = all full_audit:facility = local5 full_audit:priority = notice comment = Обменник path = /exchanger read only = No create mask = 0777 force create mode = 0777 directory mask = 0777 veto files = /autorun.*/*sex*/ In log.smbd [2009/07/16 17:12:29, 0] modules/vfs_full_audit.c:log_success(682) log_success() failed to get vfs_handle->data! [2009/07/16 17:12:29, 0] modules/vfs_full_audit.c:log_success(682) log_success() failed to get vfs_handle->data! [2009/07/16 17:12:29, 0] modules/vfs_full_audit.c:log_success(682) log_success() failed to get vfs_handle->data! [2009/07/16 17:12:34, 0] modules/vfs_full_audit.c:log_success(682) log_success() failed to get vfs_handle->data! [2009/07/16 17:12:34, 0] modules/vfs_full_audit.c:log_success(682) log_success() failed to get vfs_handle->data! [2009/07/16 17:12:34, 0] modules/vfs_full_audit.c:log_success(682) log_success() failed to get vfs_handle->data! [2009/07/16 17:12:34, 0] modules/vfs_full_audit.c:log_success(682) log_success() failed to get vfs_handle->data! I try another versions of samba, do not work all the same
Can you try this with Samba 3.4.0 (the latest release) to see if you can reproduce please. 3.0.x is now out of maintenance. Jeremy.
I run into this problem when trying to test my patch for Bug #4025, when running compiled from master.
If you can get me more info how to reproduce this, it would be great! Volker
Created attachment 5354 [details] My smb conf used with the master branch
reproduction: use the posted smb.conf, run smbclient, copy some file, and check the logs. When it's running the SMB_VFS_HANDLE_GET_DATA macro, the handle is lost.
Okay, we're calling REALPATH before CONNECT.... Volker
Jeremy, the canonicalize_connect_path() calls in make_connection_snum() call the VFS REALPATH operation before the VFS_CONNECT operation. I don't know if that's intended, so far I thought the VFS calls CONNECT first. Volker
*** Bug 6882 has been marked as a duplicate of this bug. ***
This is a horrible chicken and egg problem. We need to call VFS_REALPATH in order for the path in the conn struct to be correct for the VFS_CONNECT. If we call the VFS_CONNECT first, we cannot guarantee that the conn->connectpath is correct. Inside connection_struct we have: char *dirpath; <--- used in old 8.3 directory traversals. char *connectpath; <--- the actual path used on the filesystem for this share. char *origpath; <--- what was used in path="" in smb.conf. Ideas needed for the right way to fix this. Jeremy.
A new VFS_INIT operation? Volker
Created attachment 5369 [details] git-am patch for 3.5.0rc3 Fix bug #6557 - Do not work VFS full_audit Re-arrange the operations order so SMB_VFS_CONNECT is done first as root (to allow modules to correctly initialize themselves). Reviewed modules to check if they needed CONNECT invoked as a user (which we previously did) and it turns out any of them that cared needed root permissions anyway. Jeremy.
Created attachment 5370 [details] git-am patch for 3.4.6.
Created attachment 5371 [details] git-am fix for 3.3.11. Volker, once you're reviewed please assign to Karolin for inclusion. Thanks ! Jeremy.
Comment on attachment 5369 [details] git-am patch for 3.5.0rc3 Trusting you that you checked the VFS modules... :-)
Karo, please pull into the branches. This is a required patch for the wide links issue. Volker
Pushed to all branches. Closing out bug report. Thanks!
FYI Volker, I checked the full_audit module with this patch. Jeremy.