I will attach patches
Created attachment 4015 [details] Allow distribution specific PERSISTENT_DB_DIR
Created attachment 4016 [details] Redirect output to stderr
Created attachment 4017 [details] DONE: Remove bashism: "&> word" should be ">word 2>&1"
Created attachment 4018 [details] Renamed functions 'start' by 'start_server' for better readability Renamed functions 'start', 'stop' and 'restart' by 'start_server', 'stop_server' and 'restart_server' for better readability
Created attachment 4019 [details] Replace the deprecated and bash-only $"string" syntax by eval_gettext
Created attachment 4020 [details] set PATH to have consistent behavior and test if daemon is here - set PATH to have consistent behavior - test if daemon is here
Created attachment 4021 [details] Added debian-like LSB functions
Created attachment 4022 [details] Add function 'running'
Created attachment 4023 [details] Use ctdb ping to check status
Created attachment 4024 [details] First try to cleanly stop ctdb before killing it
Created attachment 4025 [details] Show progress during start/stop/restart/...
Created attachment 4026 [details] Threat warnings as errors
Created attachment 4027 [details] Return value is 1 in "status" when ctdb is not running
Created attachment 4028 [details] Use start_server instead of restart_server iwth cron
Created attachment 4029 [details] Be more verbose with the cron command
Created attachment 4030 [details] Replaced ubuntu by debian, as ubuntu is debian-based. Replaced ubuntu by debian, as ubuntu is debian-based.
Created attachment 4441 [details] Current version (1.0.87) This patch include: - PERSISTENT_DB_DIR for debian and ubuntu - LSB support - pure gettext (without bashism) - code refactorisation
(In reply to comment #16) > Created an attachment (id=4030) [details] > Replaced ubuntu by debian, as ubuntu is debian-based. > > Replaced ubuntu by debian, as ubuntu is debian-based. Oops I have meanwhile committed a corresponding patch myself. Somehow I wasn't aware that you proposed a patch here. This will be in 1.0.91.
Ok, this is quite a list... =) I don't expect all of the patches to still apply. I will try and look into these soon... Michael
Created attachment 5102 [details] Allow distribution specific PERSISTENT_DB_DIR
Comment on attachment 4017 [details] DONE: Remove bashism: "&> word" should be ">word 2>&1" Att 4017 has already been done at http://git.samba.org/?p=sahlberg/ctdb.git;a=commitdiff;h=951dbcb29fd53cf51a08958efe185db4954d24f3
All of this was written with much of the functionality going into ctdbd_wrapper. Haven't heard any complaints about initscript in recent times. OK to close this after all this time? :-)
Fixed in all currently supported versions.