Bug 5159 - is there a umount.cifs fix for ctdb version of samba?
Summary: is there a umount.cifs fix for ctdb version of samba?
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: Client Tools (show other bugs)
Version: 3.0.26
Hardware: Other Linux
: P3 regression
Target Milestone: none
Assignee: Jeff Layton
QA Contact: Samba QA Contact
Depends on: 4784
  Show dependency treegraph
Reported: 2007-12-22 11:41 UTC by Michael Vitale
Modified: 2009-05-04 06:23 UTC (History)
0 users

See Also:

cannonicalize argument provided to umount.cifs (1.43 KB, patch)
2009-02-03 17:11 UTC, shirishpargaonkar@gmail.com
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Vitale 2007-12-22 11:41:03 UTC
I found bug 4736 which says:
this is a duplicate of bug #4784, which has been fixed in 3.0.27a.

I have checked out the current ctdb version of samba, Version 3.0.26pre1-SVN-build-UNKNOWN

Is there a workaround for me or do I appply the source code fix as documented in the referred bug, 4784?

/usr/samba-ctdb/bin/umount.cifs //
This utility only unmounts cifs filesystems.
Comment 1 Michael Vitale 2007-12-22 11:43:15 UTC
Added bug dependency: 4784
Comment 2 Michael Vitale 2007-12-22 20:38:55 UTC
The error line from umount is misleading:
This utility only unmounts cifs filesystems.

I added strerror debug logic to that error branch and found out if failed because
I provided the share name, not the actual mount point, to umount, since the real error is:
No such file or directory

I recommend changing the code accordingly in umount.cifs.c.

On a side note, please explain to me why I provide the share name when calling umount after a mount -t cifs
but provide the actual mount point to umount if using mount.cifs

Comment 3 shirishpargaonkar@gmail.com 2009-02-03 17:11:45 UTC
Created attachment 3912 [details]
cannonicalize argument provided to umount.cifs

I attached a patch under bug 4370, which should fix this problem also.
Attaching the attachment here as well.
Comment 4 Jeff Layton 2009-05-04 06:23:48 UTC
Patch went into master branch in February. Closing case.