Bug 4132 - temp file not removed on siganl (e.g. SIGINT)
Summary: temp file not removed on siganl (e.g. SIGINT)
Status: CLOSED FIXED
Alias: None
Product: rsync
Classification: Unclassified
Component: core (show other bugs)
Version: 2.6.7
Hardware: Other All
: P3 normal (vote)
Target Milestone: ---
Assignee: Wayne Davison
QA Contact: Rsync QA Contact
URL:
Keywords:
: 4130 4131 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-09-28 19:17 UTC by mugi@pinesalad.net
Modified: 2006-10-15 13:26 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description mugi@pinesalad.net 2006-09-28 19:17:30 UTC
Using any partial options (-P, --partial, --partial-dir) an interrupted rsync does create a partial file, however upon resuming and completion of the transfer the partial file is not removed.

Steps to reproduce:

1. working and verified rsync setup between two systems

2. run rsync with a somewhat large file in the source dir so you have a chance to interrupt it, use one of the partial options

Here's my example with a partial and temp directory set in the user (xfer) that is running the rsync job:

rsync -av --partial-dir=~xfer/partial --temp-dir=~xfer/tmp /xfer/outbox/* remoteserver:/xfer/inbox/

I'm putting a 200MB+ file in /xfer/outbox

3. Interrupt rsync with a Ctrl-C

4. Verify partial file is created on the remoteserver (in my example, look in ~xfer/partial directory on the remote server)

5. Run the same rsync command to let it continue/resume

6. Upon completion of the job, look on the remoteserver and you will see the partial file still exists (again, in my example the ~xfer/partial directory on the remote server).


I have verified the file remains with any of the partial options and using directories outside of the rsync tree that is being copied/updated.

2.6.8 source compiled on AIX 5.3
Have also tried cygwin and suse flavors.
Comment 1 mugi@pinesalad.net 2006-09-28 19:19:23 UTC
*** Bug 4130 has been marked as a duplicate of this bug. ***
Comment 2 mugi@pinesalad.net 2006-09-28 19:19:56 UTC
*** Bug 4131 has been marked as a duplicate of this bug. ***
Comment 3 Wayne Davison 2006-09-29 14:51:38 UTC
It's rsync's temp file that is not being cleaned up, not a "partial file" (which is something else in rsync's nomenclature).

Here's my earlier email on the subject, complete with patch:

http://lists.samba.org/archive/rsync/2006-May/015608.html