Bug 15673 - --version-* options are still not ergonomic, and they reject tilde characters
Summary: --version-* options are still not ergonomic, and they reject tilde characters
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Build (show other bugs)
Version: 4.20.0
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jule Anger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-06-26 23:14 UTC by Douglas Bagnall
Modified: 2024-08-15 12:14 UTC (History)
4 users (show)

See Also:


Attachments
Patches for v4-20-test (5.19 KB, text/plain)
2024-07-03 10:20 UTC, Stefan Metzmacher
dbagnall: review+
Details
Patches for v4-19-test (5.19 KB, patch)
2024-07-03 10:21 UTC, Stefan Metzmacher
dbagnall: review+
Details
Additional regression fix for v4-21-test (4.25 KB, text/plain)
2024-08-06 07:37 UTC, Stefan Metzmacher
asn: review+
Details
Additional regression fix for v4-20-test (4.25 KB, text/plain)
2024-08-06 07:38 UTC, Stefan Metzmacher
asn: review+
Details
Additional regression fix for v4-19-test (4.25 KB, text/plain)
2024-08-06 07:38 UTC, Stefan Metzmacher
asn: review+
Details
Additional regression fix for v4-21-test / tdb 1.4.12 (8.13 KB, text/plain)
2024-08-06 22:03 UTC, Stefan Metzmacher
asn: review+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Douglas Bagnall 2024-06-26 23:14:44 UTC
a follow-up to https://bugzilla.samba.org/show_bug.cgi?id=15654

This met some real-world problems, as described in
https://lists.samba.org/archive/samba-technical/2024-June/139020.html

and we might as well fix them immediately.

 * --vendor-patch-revision and --vendor-name are more options than you need
 * Common version characters like '~' are not accepted.
Comment 1 Samba QA Contact 2024-07-03 02:36:12 UTC
This bug was referenced in samba master:

0bc5b6f29307ce758774c1b2f48ce62315fdc7f9
673c8e6ca5994973e4887641c3599707a66a608c
Comment 2 Stefan Metzmacher 2024-07-03 10:20:34 UTC
Created attachment 18362 [details]
Patches for v4-20-test
Comment 3 Stefan Metzmacher 2024-07-03 10:21:20 UTC
Created attachment 18363 [details]
Patches for v4-19-test
Comment 4 Jule Anger 2024-07-09 07:20:25 UTC
Pushed to autobuild-v4-{20,19}-test.
Comment 5 Samba QA Contact 2024-07-09 08:47:11 UTC
This bug was referenced in samba v4-19-test:

fe5f703e4280eea502a5dbb3ca854c345b499aa6
a65eda03caa4e22c40893333f05f75d3208098dc
Comment 6 Samba QA Contact 2024-07-09 09:44:12 UTC
This bug was referenced in samba v4-20-test:

5531ef4d2b0569ded5f9be4396c84acc5042ce55
95058b97865cf179467e6d85a2f92ad8c27c0513
Comment 7 Jule Anger 2024-07-09 09:54:06 UTC
Closing out bug report.

Thanks!
Comment 8 Samba QA Contact 2024-08-02 12:14:55 UTC
This bug was referenced in samba v4-20-stable (Release samba-4.20.3):

5531ef4d2b0569ded5f9be4396c84acc5042ce55
95058b97865cf179467e6d85a2f92ad8c27c0513
Comment 9 Guenther Deschner 2024-08-04 00:09:58 UTC
It seems like this is causing issues with symbol versioning in general, just like described in the fedora 40 samba 4.20.3 update here: 
https://bodhi.fedoraproject.org/updates/FEDORA-2024-e6e22b06ef
Comment 10 Douglas Bagnall 2024-08-04 00:21:54 UTC
(In reply to Guenther Deschner from comment #9)
Sorry, it's actually the fix that broke that, by turning dots into underscores.

See https://lists.samba.org/archive/samba/2024-July/249558.html
Comment 11 Andreas Schneider 2024-08-05 12:45:56 UTC
Our ABI is using:

SYMBOLNAME_MAJOR.MINOR.PATCH

libndr-krb5pac.so.0(NDR_KRB5PAC_0.0.1)

It needs to stay that way. Changing the dots to underscore breaks the ABI of all libraries. We actually broke the complete ABI with Samba 4.20.3!
Comment 12 Samba QA Contact 2024-08-06 00:43:03 UTC
This bug was referenced in samba master:

46215ab1b34aa79c4c831ea1c12f73eacf1e8a12
Comment 13 Stefan Metzmacher 2024-08-06 07:37:24 UTC
Created attachment 18393 [details]
Additional regression fix for v4-21-test
Comment 14 Stefan Metzmacher 2024-08-06 07:38:01 UTC
Created attachment 18394 [details]
Additional regression fix for v4-20-test
Comment 15 Stefan Metzmacher 2024-08-06 07:38:51 UTC
Created attachment 18395 [details]
Additional regression fix for v4-19-test
Comment 16 Samba QA Contact 2024-08-06 09:22:04 UTC
This bug was referenced in samba v4-20-test:

181b79a9ff6f0971992f15b988d84b6caa8aa045
Comment 17 Samba QA Contact 2024-08-06 10:41:48 UTC
This bug was referenced in samba v4-20-stable (Release samba-4.20.4):

181b79a9ff6f0971992f15b988d84b6caa8aa045
Comment 18 Samba QA Contact 2024-08-06 11:44:04 UTC
This bug was referenced in samba v4-19-test:

ab535a64d26f17dac1befb8b6470c901003f5186
Comment 19 Samba QA Contact 2024-08-06 12:50:12 UTC
This bug was referenced in samba v4-21-test:

6d69562e27c41ae24650304eb7b668f28e49d68d
Comment 20 Samba QA Contact 2024-08-06 16:17:03 UTC
This bug was referenced in samba master:

bcd49e3000736eb3c642280ac2e1f3d56a31b6bb
6b10cfbaf2c522cceb48c610c18656d2d69cf60b
Comment 21 Stefan Metzmacher 2024-08-06 22:03:23 UTC
Created attachment 18396 [details]
Additional regression fix for v4-21-test / tdb 1.4.12
Comment 22 Samba QA Contact 2024-08-07 11:16:11 UTC
This bug was referenced in samba v4-21-test:

0cf9c6efd7eac8fa026bac7d79b4f4f3ef01450c
0ca6cd90b661ee8002dd55f408b525003ac415a1
Comment 23 Samba QA Contact 2024-08-13 17:03:06 UTC
This bug was referenced in samba v4-21-stable (Release samba-4.21.0rc2):

6d69562e27c41ae24650304eb7b668f28e49d68d
0cf9c6efd7eac8fa026bac7d79b4f4f3ef01450c
0ca6cd90b661ee8002dd55f408b525003ac415a1
Comment 24 Samba QA Contact 2024-08-15 12:14:26 UTC
This bug was referenced in samba v4-19-stable (Release samba-4.19.8):

fe5f703e4280eea502a5dbb3ca854c345b499aa6
a65eda03caa4e22c40893333f05f75d3208098dc
ab535a64d26f17dac1befb8b6470c901003f5186