a follow-up to https://bugzilla.samba.org/show_bug.cgi?id=15654 This met some real-world problems, as described in https://lists.samba.org/archive/samba-technical/2024-June/139020.html and we might as well fix them immediately. * --vendor-patch-revision and --vendor-name are more options than you need * Common version characters like '~' are not accepted.
This bug was referenced in samba master: 0bc5b6f29307ce758774c1b2f48ce62315fdc7f9 673c8e6ca5994973e4887641c3599707a66a608c
Created attachment 18362 [details] Patches for v4-20-test
Created attachment 18363 [details] Patches for v4-19-test
Pushed to autobuild-v4-{20,19}-test.
This bug was referenced in samba v4-19-test: fe5f703e4280eea502a5dbb3ca854c345b499aa6 a65eda03caa4e22c40893333f05f75d3208098dc
This bug was referenced in samba v4-20-test: 5531ef4d2b0569ded5f9be4396c84acc5042ce55 95058b97865cf179467e6d85a2f92ad8c27c0513
Closing out bug report. Thanks!
This bug was referenced in samba v4-20-stable (Release samba-4.20.3): 5531ef4d2b0569ded5f9be4396c84acc5042ce55 95058b97865cf179467e6d85a2f92ad8c27c0513
It seems like this is causing issues with symbol versioning in general, just like described in the fedora 40 samba 4.20.3 update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-e6e22b06ef
(In reply to Guenther Deschner from comment #9) Sorry, it's actually the fix that broke that, by turning dots into underscores. See https://lists.samba.org/archive/samba/2024-July/249558.html
Our ABI is using: SYMBOLNAME_MAJOR.MINOR.PATCH libndr-krb5pac.so.0(NDR_KRB5PAC_0.0.1) It needs to stay that way. Changing the dots to underscore breaks the ABI of all libraries. We actually broke the complete ABI with Samba 4.20.3!
This bug was referenced in samba master: 46215ab1b34aa79c4c831ea1c12f73eacf1e8a12
Created attachment 18393 [details] Additional regression fix for v4-21-test
Created attachment 18394 [details] Additional regression fix for v4-20-test
Created attachment 18395 [details] Additional regression fix for v4-19-test
This bug was referenced in samba v4-20-test: 181b79a9ff6f0971992f15b988d84b6caa8aa045
This bug was referenced in samba v4-20-stable (Release samba-4.20.4): 181b79a9ff6f0971992f15b988d84b6caa8aa045
This bug was referenced in samba v4-19-test: ab535a64d26f17dac1befb8b6470c901003f5186
This bug was referenced in samba v4-21-test: 6d69562e27c41ae24650304eb7b668f28e49d68d
This bug was referenced in samba master: bcd49e3000736eb3c642280ac2e1f3d56a31b6bb 6b10cfbaf2c522cceb48c610c18656d2d69cf60b
Created attachment 18396 [details] Additional regression fix for v4-21-test / tdb 1.4.12
This bug was referenced in samba v4-21-test: 0cf9c6efd7eac8fa026bac7d79b4f4f3ef01450c 0ca6cd90b661ee8002dd55f408b525003ac415a1
This bug was referenced in samba v4-21-stable (Release samba-4.21.0rc2): 6d69562e27c41ae24650304eb7b668f28e49d68d 0cf9c6efd7eac8fa026bac7d79b4f4f3ef01450c 0ca6cd90b661ee8002dd55f408b525003ac415a1
This bug was referenced in samba v4-19-stable (Release samba-4.19.8): fe5f703e4280eea502a5dbb3ca854c345b499aa6 a65eda03caa4e22c40893333f05f75d3208098dc ab535a64d26f17dac1befb8b6470c901003f5186