Bug 15654 - Setting VENDOR fields in VERSION is not ergonomic for packagers
Summary: Setting VENDOR fields in VERSION is not ergonomic for packagers
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Build (show other bugs)
Version: 4.20.1
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jule Anger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-29 22:38 UTC by Andrew Bartlett
Modified: 2024-08-15 12:14 UTC (History)
1 user (show)

See Also:

Attachments
patch for Samba 4.20 (7.44 KB, patch)
2024-06-04 01:04 UTC, Andrew Bartlett 		no flags Details
patch for Samba 4.19 and 4.20 (5.08 KB, patch)
2024-06-04 01:17 UTC, Andrew Bartlett 		dbagnall: review+
Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Bartlett 2024-05-29 22:38:29 UTC 
Debian in particular requests that it be possible to set the VENDOR fields in the VERSION file at ./configure time so as not to have to patch the source tree with a number that will change each release.
Comment 1 Samba QA Contact 2024-05-31 01:29:13 UTC 
This bug was referenced in samba master:

651fb94c374c7f84405d960a9e0a0fd7fcb285dd
72112d4814eb3872016c1168c477531be835a1f9
Comment 2 Andrew Bartlett 2024-06-04 01:04:13 UTC 
Created attachment 18319 [details]
patch for Samba 4.20
Comment 3 Andrew Bartlett 2024-06-04 01:17:17 UTC 
Created attachment 18320 [details]
patch for Samba 4.19 and 4.20
Comment 4 Douglas Bagnall 2024-06-12 23:42:28 UTC 
Thanks Andrew, and thanks in advance Jule!

For 4.19 and 4.20.
Comment 5 Jule Anger 2024-06-18 07:25:37 UTC 
Pushed to autobuild-v4-{20,19}-test.
Comment 6 Samba QA Contact 2024-06-18 08:34:29 UTC 
This bug was referenced in samba v4-20-test:

5d593a735d371774b5a8847a4e820c894ec3e25f
dceb2e56b63c27ebe174b58c2bd5fab1fd3e4415
Comment 7 Samba QA Contact 2024-06-19 14:34:49 UTC 
This bug was referenced in samba v4-20-stable (Release samba-4.20.2):

5d593a735d371774b5a8847a4e820c894ec3e25f
dceb2e56b63c27ebe174b58c2bd5fab1fd3e4415
Comment 8 Samba QA Contact 2024-07-03 09:57:14 UTC 
This bug was referenced in samba v4-19-test:

80655e221365799e37f70eef55fd92fd3ddcfde4
f525d2fef3d755269db3800627704a5b03b244c0
Comment 9 Jule Anger 2024-07-03 10:05:13 UTC 
Closing out bug report.

Thanks!
Comment 10 Samba QA Contact 2024-08-15 12:14:12 UTC 
This bug was referenced in samba v4-19-stable (Release samba-4.19.8):

80655e221365799e37f70eef55fd92fd3ddcfde4
f525d2fef3d755269db3800627704a5b03b244c0