Bug 15157 - Make use of glfs_*at() API calls in vfs_glusterfs
Summary: Make use of glfs_*at() API calls in vfs_glusterfs
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: VFS Modules (show other bugs)
Version: 4.17.0rc3
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jule Anger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-24 18:12 UTC by Anoop C S
Modified: 2022-09-22 06:02 UTC (History)
2 users (show)

See Also:

Attachments
patch for v4-17 (28.99 KB, patch)
2022-08-29 11:02 UTC, Anoop C S 		gd: review+
jra: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anoop C S 2022-08-24 18:12:54 UTC 
Implementations are now available via libgfapi for *at() variants of many syscalls used in VFS module for GlusterFS. Let's make use of those to better safe guard against symlink races.

* https://github.com/gluster/glusterfs/blob/devel/api/src/gfapi.map#L285
Comment 1 Samba QA Contact 2022-08-26 17:34:04 UTC 
This bug was referenced in samba master:

5f51fa9c07e194bcc3c4f39a1bfc2e01139c917b
3425fa0daf9e32d09c7716692cdfdffdc09856d7
184a9913241acd4f69128ced3370d3bf49b95f3b
56c4aab11190b8d48a5b92babea7fc7e78b54b4e
2b721ff22be04cea90086dde2a50f4287d075326
2fa71202ab347fd057bb9b42740e57344e2679e1
b2746eb5fa64e0ec58e99eed5be10c98ea4e1c1e
58b6cdabc0c3d788b407d3bfa46570311e910180
21654af5a5a062d831f7cb1efec1f1b1eb333bd2
a4235200383fa4dc2f376ce042ed067a45f105d5
310a908098b4ff3130a61594c15e91d5e561f357
55548d7405ceca1d20e788a459e685c56f2ff139
65f4c4e31e4cc60eb9ebca3858275a29f43d5e12
b7c460b902800c0156385b2edb82efb07f561c51
Comment 2 Anoop C S 2022-08-29 11:02:16 UTC 
Created attachment 17502 [details]
patch for v4-17
Comment 3 Anoop C S 2022-08-29 11:03:17 UTC 
Assigning to Jule for inclusion in 4.17.rcNext
Comment 4 Guenther Deschner 2022-08-29 12:54:27 UTC 
Comment on attachment 17502 [details]
patch for v4-17

LGTM, thanks!
Comment 5 Samba QA Contact 2022-08-30 10:46:11 UTC 
This bug was referenced in samba v4-17-test:

9f04cb8f58d6dbda2769a57fcc6ec0a3fb137ccd
a8eab509154fcd0b93b193ead231a7b62f28d38d
e0375100d798459d87d51c300f87049baf1027c2
a41e308cf080d7f202ab29c88c96fb08e604a1e3
618c868642d7e09ac467e73195e6638853bd5096
c9b0459a1755832f6279f955e1cbca2d74b08f8d
41eb80482b34ec91306ca73a43ee21d3898b2c55
894338eddbbcacced2908da4aa0fd3d11d3e096c
1d74f92deb43b7843ce44c79209965e13fd580f0
5e155ea4505adcb839fdf92f3083c7b7a43e3131
5e26c570b7cb09f5e3e9ecd58bed7e01f4bc4808
9d11c39a2b8d2c508d448f08e718009d9a5e44e7
d5831b0f09803db0309c013e3499ff0fa95c0c8c
ffe95221aab1db375de704b366971ef99398577d
Comment 6 Jule Anger 2022-08-30 11:21:36 UTC 
Closing out bug report.

Thanks!
Comment 7 Samba QA Contact 2022-08-30 15:08:30 UTC 
This bug was referenced in samba v4-17-stable (Release samba-4.17.0rc4):

9f04cb8f58d6dbda2769a57fcc6ec0a3fb137ccd
a8eab509154fcd0b93b193ead231a7b62f28d38d
e0375100d798459d87d51c300f87049baf1027c2
a41e308cf080d7f202ab29c88c96fb08e604a1e3
618c868642d7e09ac467e73195e6638853bd5096
c9b0459a1755832f6279f955e1cbca2d74b08f8d
41eb80482b34ec91306ca73a43ee21d3898b2c55
894338eddbbcacced2908da4aa0fd3d11d3e096c
1d74f92deb43b7843ce44c79209965e13fd580f0
5e155ea4505adcb839fdf92f3083c7b7a43e3131
5e26c570b7cb09f5e3e9ecd58bed7e01f4bc4808
9d11c39a2b8d2c508d448f08e718009d9a5e44e7
d5831b0f09803db0309c013e3499ff0fa95c0c8c
ffe95221aab1db375de704b366971ef99398577d