Bug 15092 - vfs_gluster broken, vfs_ceph possibly broken
Summary: vfs_gluster broken, vfs_ceph possibly broken
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: VFS Modules (show other bugs)
Version: unspecified
Hardware: All All
: P5 regression (vote)
Target Milestone: ---
Assignee: Guenther Deschner
QA Contact: Samba QA Contact
Depends on:
Reported: 2022-06-09 12:51 UTC by Volker Lendecke
Modified: 2023-03-07 16:27 UTC (History)
2 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Volker Lendecke 2022-06-09 12:51:16 UTC
Due to VFS changes with 4.17 (for example no valid stat in smb_fname when SMB_VFS_OPENAT is called), at the moment the libgfapi gluster backend is broken in Samba. vfs_ceph being the other big library-based VFS module might also be affected.

Upstream Samba has no way of properly fixing this due to the lack of gluster and ceph environments in autobuild or gitlab CI.

Marking this bug as a known regression that needs fixing by people with access to a working gluster setup, likewise ceph.
Comment 1 Volker Lendecke 2022-06-09 12:52:10 UTC
Assigning to Günther, I had talked to him before I have submitted the merge request breaking the Samba gluster VFS module.
Comment 2 Anoop C S 2022-06-23 10:33:07 UTC
I am yet to figure out(and fix) the issues w.r.t snapshot consumption using vfs_shadow_copy2 module but otherwise things are expected to work() after 767ede0064ce9a9d0576a337b2059f4ba3a6adeb and 0633d8837ce4ddcf7f46c5f320e8d0b3142177fa.
Comment 3 Guenther Deschner 2022-06-23 14:56:50 UTC
For reference added upstream glusterfs github issue tracking the addition of various 'at' calls to gluster gfapi.
Comment 4 Anoop C S 2022-08-03 11:18:51 UTC
(In reply to Anoop C S from comment #2)
I managed to figure out the root cause of problems while accessing GlusterFS snapshots using vfs_shadow_copy2 module and a preparatory patch[1] is already merged in libgfapi. With one more final patch[2] this functionality should be working as before.

[1] https://github.com/gluster/glusterfs/pull/3650
[2] https://github.com/gluster/glusterfs/pull/3667

(In reply to Guenther Deschner from comment #3)
Following _at() variants are now available with GlusterFS's libgfapi:


I'll come up with the required changes in vfs_glusterfs to consume those new APIs.
Comment 5 Anoop C S 2022-09-22 06:02:44 UTC
(In reply to Anoop C S from comment #4)
Starting with 4.17, vfs_glusterfs[1][2] make use of *_at() calls from libgfapi.

[1] https://gitlab.com/samba-team/samba/-/merge_requests/2682
[2] https://bugzilla.samba.org/show_bug.cgi?id=15157
Comment 6 Guenther Deschner 2023-03-07 16:27:25 UTC
Both vfs gluster and vfs ceph have seen a couple of related fixes and are known to work properly with current master/4.18.0 and 4.17.x releases

Closing as fixed.