Bug 14265 - winbindd_getgrgid continues with a null SID and produces confusing log messages
Summary: winbindd_getgrgid continues with a null SID and produces confusing log messages
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Winbind (show other bugs)
Version: 4.12.0rc2
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-05 12:51 UTC by Stefan Metzmacher
Modified: 2020-02-12 08:24 UTC (History)
2 users (show)

See Also:

Attachments
Patches for v4-12-test (1.42 KB, patch)
2020-02-10 10:37 UTC, Stefan Metzmacher 		asn: review+
Details
Patches for v4-11-test (1.42 KB, patch)
2020-02-10 10:38 UTC, Stefan Metzmacher 		asn: review+
Details
Patches for v4-10-test (1.42 KB, patch)
2020-02-10 10:38 UTC, Stefan Metzmacher 		asn: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Metzmacher 2020-02-05 12:51:27 UTC 
While debugging something else I found a case where
wb_lookupsid_send() tried to resolve a Null-SID, when called via
wb_getgrsid_send().

The thing is that wb_xids2sids_recv() can return a NT_STATUS_OK
together with a Null-SID in order to indicate that the uid/gid
can't be mapped to a valid SID.

winbindd_getpwuid_uid2sid_done() has a is_null_sid() check
and returns NT_STATUS_NO_SUCH_USER, but this is missing
in winbindd_getgrgid_gid2sid_done()
Comment 1 Stefan Metzmacher 2020-02-10 10:37:53 UTC 
Created attachment 15779 [details]
Patches for v4-12-test
Comment 2 Stefan Metzmacher 2020-02-10 10:38:27 UTC 
Created attachment 15780 [details]
Patches for v4-11-test
Comment 3 Stefan Metzmacher 2020-02-10 10:38:53 UTC 
Created attachment 15781 [details]
Patches for v4-10-test
Comment 4 Andreas Schneider 2020-02-10 13:40:06 UTC 
Karolin, please apply the patches to the relevant branches. Thanks!
Comment 5 Karolin Seeger 2020-02-11 07:50:56 UTC 
(In reply to Andreas Schneider from comment #4)
Pushed to autobuild-v4-{12,11,10}-test.
Comment 6 Karolin Seeger 2020-02-12 08:24:27 UTC 
(In reply to Karolin Seeger from comment #5)
Pushed to all branches.
Closing out bug report.

Thanks!