From b2c6601af4ebdfc5a39e07ba8e958480e77f555e Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Wed, 22 Jan 2020 17:00:07 +0000 Subject: [PATCH] winbindd: handling missing idmap in getgrgid() A similar hunk was added via commit 89f753c1fc824fef29aebb7d783ab7e09cd1f04e ("winbind: Use xids2sids in getpwuid"), but it was missing in commit e2dda192e7f8b65a5f02120be56cf0f07d03679f ("winbind: Use xids2sids in getgrgid") BUG: https://bugzilla.samba.org/show_bug.cgi?id=14265 Signed-off-by: Stefan Metzmacher Reviewed-by: Andreas Schneider Autobuild-User(master): Andreas Schneider Autobuild-Date(master): Wed Feb 5 17:56:58 UTC 2020 on sn-devel-184 (cherry picked from commit 4d0bda9467ac3f45f85f48a281cdb173ce1064eb) --- source3/winbindd/winbindd_getgrgid.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/source3/winbindd/winbindd_getgrgid.c b/source3/winbindd/winbindd_getgrgid.c index aa99e6e25610..24d70161770a 100644 --- a/source3/winbindd/winbindd_getgrgid.c +++ b/source3/winbindd/winbindd_getgrgid.c @@ -79,6 +79,10 @@ static void winbindd_getgrgid_gid2sid_done(struct tevent_req *subreq) if (tevent_req_nterror(req, status)) { return; } + if (is_null_sid(state->sid)) { + tevent_req_nterror(req, NT_STATUS_NO_SUCH_GROUP); + return; + } subreq = wb_getgrsid_send(state, state->ev, state->sid, lp_winbind_expand_groups()); -- 2.17.1