Bug 140 - 64-bit signed time_t causes corrupt timestamps on server
Summary: 64-bit signed time_t causes corrupt timestamps on server
Status: VERIFIED FIXED
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: File Services (show other bugs)
Version: 3.0.0preX
Hardware: All Linux
: P2 normal
Target Milestone: none
Assignee: Gerald (Jerry) Carter (dead mail address)
QA Contact:
URL: http://bugs.debian.org/194075
Keywords:
: 1091 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-05-31 21:28 UTC by Steve Langasek
Modified: 2005-11-14 09:24 UTC (History)
1 user (show)

See Also:


Attachments
one-liner patch to fix timestamps on Linux/Alpha (591 bytes, patch)
2003-05-31 22:22 UTC, Steve Langasek
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Langasek 2003-05-31 21:28:45 UTC
Viewing the properties of a writable file on the server using Win2K or WinXP
file explorer corrupts the file's timestamp when running on Linux/Alpha.  The
client sends a trans2 SET_FILE_BASIC_INFO command with all times set to
0xffffffffffffffff.  Normally, this causes the timestamp conversion routine to
reject the timestamp as invalid, converting it to 0; however, it does this only
as a side-effect, and not because it recognizes 0xffffffffffffffff as a special
value.  On most systems, this will result in a timestamp value that's outside of
the range (TIME_T_MAX,TIME_T_MIN) -- *except* on machines which support a 64-bit
signed time_t, such as Linux/Alpha.  The fix is to recognize this special value
and convert it to 0 on all platforms.

Patch to follow.
Comment 1 Steve Langasek 2003-05-31 22:22:08 UTC
Created attachment 17 [details]
one-liner patch to fix timestamps on Linux/Alpha
Comment 2 Tim Potter 2003-06-09 21:35:51 UTC
Tridge has applied this patch.

Steve, can you test and mark as validated?
Comment 3 Steve Langasek 2003-06-09 22:41:37 UTC
confirmed, the patch committed to CVS looks correct.
Comment 4 Jim McDonough 2004-02-17 14:15:55 UTC
*** Bug 1091 has been marked as a duplicate of this bug. ***
Comment 5 Gerald (Jerry) Carter (dead mail address) 2005-02-07 07:56:56 UTC
originally reported against 3.0aph24.  Bugzilla spring cleaning.  
Removing old alpha versions.
Comment 6 Gerald (Jerry) Carter (dead mail address) 2005-11-14 09:24:55 UTC
database cleanup