I tried to start samba on Ubunut-server 16.04 via ctdb. Start failed with error: --------- 2016/10/06 18:31:32.357887 [29921]: 50.samba: Failed to start samba.service: Unit samba.service is masked. --------- I figured out, that Ubuntu is not using samba.service to start smbd and nmbd, insted smbd.service and nmbd.service is used. So I change /etc/ctdb/events.d/50.samba as followed: --------- debian) CTDB_SERVICE_SMB=${CTDB_SERVICE_SMB:-smbd} CTDB_SERVICE_NMB=${CTDB_SERVICE_NMB:-nmbd} ;; --------- after that Samba will start via CTDB. I think it will be the same on debian-systems, so the script should be changed
Andrew, given that you're a Debian maintainer (or similar) for Samba, can you please comment on how CTDB should be starting/stopping smb and nmb services? Until now we have used the "samba" initscript. However, it looks to me as though Debian as if the "samba" initscript is probably deprecated from jessie onwards, so we should be using "smbd" and "nmbd" these days. Thanks...
Stefan, you know you can just do this in your CTDB configuration file? CTDB_SERVICE_SMB=smbd CTDB_SERVICE_NMB=nmbd We'll obviously fix the default if a change makes sense, but you don't actually need to edit the event script. :-)
Hello all, I can confirm that the correct fix is what Stefan said. this bug was introduced in 2:4.4.4+dfsg-2 (i.e jessie should not be affected) while fixing <https://bugs.debian.org/828137>. I'll fix this in 2:4.4.7+dfsg-1. Also, we have a bunch of systemd patches in Debian, we need to forward them.
(In reply to Mathieu Parent from comment #3) > Also, we have a bunch of systemd patches in Debian, we need to forward them. This is https://bugzilla.samba.org/show_bug.cgi?id=12402
Created attachment 12617 [details] CTDB: Fix samba eventscript And here's the patch that'll go in next upload to sid.
(In reply to Mathieu Parent from comment #5) OK, want to re-attach with a Signed-off-by: tag? jessie has the new smbd and nmbd services/initscripts, but also has the old samba initscript for backward compatibility. So, at this stage I think we can safely make the change.
Created attachment 12621 [details] CTDB: Fix samba eventscript The signed-off patch.
Stefan, do you wanted Reported-by:, Signed-off-by; or neither? :-) I can add whatever you want when it goes into master...
Mathieu and Stefan have agreed to both sign off on the patch. I'll post it to master now and will add new cherry-picked attachments after it lands.
Created attachment 12665 [details] Patch for 4.4 and 4.5 Same patch applies cleanly to both v4-5-test and v4-4-test.
Hi Karolin, This is ready for v4-4 and v4-5. Same patch applies to both.
(In reply to Amitay Isaacs from comment #11) Pushed to autobuild-v4-{5,4}-test.
(In reply to Karolin Seeger from comment #12) Pushed to both branches. Closing out bug report. Thanks!