Bug 12402 - systemd improvements
Summary: systemd improvements
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Other (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Andrew Bartlett
QA Contact: Samba QA Contact
URL: https://bugs.debian.org/828730
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-31 13:56 UTC by Mathieu Parent
Modified: 2025-02-20 22:22 UTC (History)
8 users (show)

See Also:

Attachments
systemd: syslog.target is obsolete (2.02 KB, patch)
2016-10-31 13:56 UTC, Mathieu Parent 		no flags Details
Add documentation to systemd Unit files (2.12 KB, patch)
2016-10-31 13:57 UTC, Mathieu Parent 		no flags Details
Fix kill path in units (2.20 KB, patch)
2016-10-31 13:58 UTC, Mathieu Parent 		no flags Details
Add documentation to systemd Unit files (2.15 KB, patch)
2016-10-31 14:06 UTC, Mathieu Parent 		no flags Details
nmbd requires a working network (824 bytes, patch)
2016-10-31 19:52 UTC, Mathieu Parent 		no flags Details
systemd improvements (7.30 KB, patch)
2016-11-01 13:16 UTC, Mathieu Parent 		no flags Details
systemd: Move PIDFile to /var/run/samba where --with-fhs is used (8.94 KB, patch)
2016-11-01 14:26 UTC, Mathieu Parent 		no flags Details
systemd: Move PIDFile to /var/run/samba where --with-fhs is used (8.89 KB, patch)
2016-11-01 14:28 UTC, Mathieu Parent 		no flags Details
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Parent 2016-10-31 13:56:34 UTC 
See various improvements to systemd units, coming from Debian.
Comment 1 Mathieu Parent 2016-10-31 13:56:56 UTC 
Created attachment 12613 [details]
systemd: syslog.target is obsolete
Comment 2 Mathieu Parent 2016-10-31 13:57:44 UTC 
Created attachment 12614 [details]
Add documentation to systemd Unit files
Comment 3 Mathieu Parent 2016-10-31 13:58:35 UTC 
Created attachment 12615 [details]
Fix kill path in units
Comment 4 Mathieu Parent 2016-10-31 14:06:31 UTC 
Created attachment 12616 [details]
Add documentation to systemd Unit files
Comment 5 Mathieu Parent 2016-10-31 19:52:54 UTC 
Created attachment 12618 [details]
nmbd requires a working network
Comment 6 Mathieu Parent 2016-11-01 13:16:11 UTC 
Created attachment 12622 [details]
systemd improvements

Replacing by an all-in-one patch, with signoff.
Comment 7 Mathieu Parent 2016-11-01 14:26:13 UTC 
Created attachment 12623 [details]
systemd: Move PIDFile to /var/run/samba where --with-fhs is used

And here is an additional patch. This one may need more discussion, I'm keeping it separate.
Comment 8 Mathieu Parent 2016-11-01 14:28:30 UTC 
Created attachment 12624 [details]
systemd: Move PIDFile to /var/run/samba where --with-fhs is used
Comment 9 Mathieu Parent 2016-11-01 18:59:30 UTC 
Adding reviewers and commiters of packaging/systemd to CC.
Comment 10 Mathieu Parent 2018-01-11 09:24:56 UTC 
I've sent this again as https://github.com/samba-team/samba/pull/121.

Please review and merge...
Comment 11 Douglas Bagnall 2025-02-20 22:22:28 UTC 
The original patch has been merged (c69938ef5cb9ee49565fae834a25541f6a5da0a8 or thereabout), but https://attachments.samba.org/attachment.cgi?id=12624 does not apply. 

That patch wants to change the PIDFile lines in /packaging/*, but the system changed in 080d590de1ff9f8ebc55aeffaea8d41991466549 to use .in files and preprocessing, with changes like this:

-PIDFile=/run/winbindd.pid
+PIDFile=@PIDDIR@/winbindd.pid

It looks to me like that offers a way of doing what the patch wants, so I will close this as FIXED.