See various improvements to systemd units, coming from Debian.
Created attachment 12613 [details] systemd: syslog.target is obsolete
Created attachment 12614 [details] Add documentation to systemd Unit files
Created attachment 12615 [details] Fix kill path in units
Created attachment 12616 [details] Add documentation to systemd Unit files
Created attachment 12618 [details] nmbd requires a working network
Created attachment 12622 [details] systemd improvements Replacing by an all-in-one patch, with signoff.
Created attachment 12623 [details] systemd: Move PIDFile to /var/run/samba where --with-fhs is used And here is an additional patch. This one may need more discussion, I'm keeping it separate.
Created attachment 12624 [details] systemd: Move PIDFile to /var/run/samba where --with-fhs is used
Adding reviewers and commiters of packaging/systemd to CC.
I've sent this again as https://github.com/samba-team/samba/pull/121. Please review and merge...
The original patch has been merged (c69938ef5cb9ee49565fae834a25541f6a5da0a8 or thereabout), but https://attachments.samba.org/attachment.cgi?id=12624 does not apply. That patch wants to change the PIDFile lines in /packaging/*, but the system changed in 080d590de1ff9f8ebc55aeffaea8d41991466549 to use .in files and preprocessing, with changes like this: -PIDFile=/run/winbindd.pid +PIDFile=@PIDDIR@/winbindd.pid It looks to me like that offers a way of doing what the patch wants, so I will close this as FIXED.