The Samba-Bugzilla – Bug 10662
Samba does not handle SID compression
Last modified: 2015-10-23 06:42:15 UTC
The current code does not handle SID compression (resource SIDs) introduced in Windows Server 2012.
A fix will go into master very soon for this, but it needs to be back ported to 4.1 and 4.0.
Someone will also attach a patch based on that fix for Samba 3.6.x (and maybe 3.5.x) for those who need the functionality.
(Both winbindd and smbd will be affected, but I selected the File services component.) Winbindd is affected because we need to update the netsamlogon cache in the winbindd paths as well.
Created attachment 10039 [details]
Resource SID compression support patch for 3.6.X
Here I have prepared a patch based on changes made on Master. It would be great if some one can review this.
Those patches look pretty much like the set I prepared.
Hasn't this bug been fixed by a checkin that Jeremy committed to master?
Does it need to be back-ported to 4.0.x and 4.1.x?
Richard, I think the patches should be backported! Could you please do that and attach them for each branch we need to apply them? Thanks!
This is fixed in master and v4-2 with commit e907f8415639d2a7cbc1cc2e40e2e35bfa0024de.
So this is not a 4.2.0 blocker.
Can someone prepare patches for v4-1-test and v4-0-test?
git cherry-pick -x -5 e907f8415639d2a7cbc1cc2e40e2e35bfa0024de
Please indicate whether this patch was incorporated into Samba 3.6.x and if so at what version. Currently 3.6.23 does not seem to contain it
(In reply to Brandon Haberfeld from comment #6)
No, you need to apply and build it yourself for 3.6.
Fixed in 4.1.20, 4.2.3 and 4.3.0, see bug #11328