Bug 9957 - Fix auto-enabling CTDB read-only records support
Summary: Fix auto-enabling CTDB read-only records support
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.0
Classification: Unclassified
Component: Clustering (show other bugs)
Version: 4.0.0
Hardware: All All
: P3 major (vote)
Target Milestone: ---
Assignee: Volker Lendecke
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-18 05:04 UTC by Daniel Gan-Levi (dead mail address)
Modified: 2020-12-11 12:41 UTC (History)
2 users (show)

See Also:

Attachments
A patch to fix auto-enabling CTDB read-only records support (1.74 KB, patch)
2013-06-18 05:04 UTC, Daniel Gan-Levi (dead mail address) 		vl: review+
Details
A patch to fix auto-enabling of CTDB readonly support (1.79 KB, patch)
2013-06-23 04:58 UTC, Daniel Gan-Levi (dead mail address) 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Gan-Levi (dead mail address) 2013-06-18 05:04:26 UTC 
Created attachment 8977 [details]
A patch to fix auto-enabling CTDB read-only records support

Ever since the commit "s3-ctdb: Enable CTDB readonly support only if CTDB supports it" (5c5111ca0319ad3fdd2c27a0bd3c06b576921d08) the read-only support could not be actually enabled, because that commit added conditional compilation but missed updating the waf build.
A patch for source3/wscript is attached - please review.
Comment 1 Christian Ambach 2013-06-18 15:59:09 UTC 
Comment on attachment 8977 [details]
A patch to fix auto-enabling CTDB read-only records support

Seems to be an obvious omission, so I would mark as Reviewed by me.
would anybody second for upstream push?
Comment 2 Christian Ambach 2013-06-21 13:44:08 UTC 
Comment on attachment 8977 [details]
A patch to fix auto-enabling CTDB read-only records support

Daniel,

before we can accept this patch upstream, we need to be clear about contribution rules: you need to sign-off this patch, either under personal copyright or by submitting a Certificate of Origin. See README.contributing.

Please indicate if it is ok to for us to include this upstream as
Signed-off-by: Daniel Gan-Levi <danielg@il.ibm.com> or if there are changes necessary.
Comment 3 Daniel Gan-Levi (dead mail address) 2013-06-23 04:58:01 UTC 
Created attachment 8991 [details]
A patch to fix auto-enabling of CTDB readonly support

Signed off this time