Bug 9957 - Fix auto-enabling CTDB read-only records support
Fix auto-enabling CTDB read-only records support
Status: RESOLVED FIXED
Product: Samba 4.0
Classification: Unclassified
Component: Clustering
4.0.0
All All
: P3 major
: ---
Assigned To: Volker Lendecke
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-18 05:04 UTC by Daniel Gan-Levi
Modified: 2013-07-25 19:29 UTC (History)
2 users (show)

See Also:
danielg: review?


Attachments
A patch to fix auto-enabling CTDB read-only records support (1.74 KB, patch)
2013-06-18 05:04 UTC, Daniel Gan-Levi
vl: review+
Details
A patch to fix auto-enabling of CTDB readonly support (1.79 KB, patch)
2013-06-23 04:58 UTC, Daniel Gan-Levi
danielg: review?
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Gan-Levi 2013-06-18 05:04:26 UTC
Created attachment 8977 [details]
A patch to fix auto-enabling CTDB read-only records support

Ever since the commit "s3-ctdb: Enable CTDB readonly support only if CTDB supports it" (5c5111ca0319ad3fdd2c27a0bd3c06b576921d08) the read-only support could not be actually enabled, because that commit added conditional compilation but missed updating the waf build.
A patch for source3/wscript is attached - please review.
Comment 1 Christian Ambach 2013-06-18 15:59:09 UTC
Comment on attachment 8977 [details]
A patch to fix auto-enabling CTDB read-only records support

Seems to be an obvious omission, so I would mark as Reviewed by me.
would anybody second for upstream push?
Comment 2 Christian Ambach 2013-06-21 13:44:08 UTC
Comment on attachment 8977 [details]
A patch to fix auto-enabling CTDB read-only records support

Daniel,

before we can accept this patch upstream, we need to be clear about contribution rules: you need to sign-off this patch, either under personal copyright or by submitting a Certificate of Origin. See README.contributing.

Please indicate if it is ok to for us to include this upstream as
Signed-off-by: Daniel Gan-Levi <danielg@il.ibm.com> or if there are changes necessary.
Comment 3 Daniel Gan-Levi 2013-06-23 04:58:01 UTC
Created attachment 8991 [details]
A patch to fix auto-enabling of CTDB readonly support

Signed off this time