Bug 9932 - Currently the maximum number of aces in an SD is limited to 1000, but Microsoft supports around 1800
Currently the maximum number of aces in an SD is limited to 1000, but Microso...
Status: NEW
Product: Samba 3.6
Classification: Unclassified
Component: SMB2
3.6.15
All All
: P5 normal
: ---
Assigned To: Jeremy Allison
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-05 21:17 UTC by Partha
Modified: 2013-06-07 23:32 UTC (History)
2 users (show)

See Also:


Attachments
attached the patch for supporting maximum number of aces limit in SAMBA (435 bytes, patch)
2013-06-05 21:39 UTC, Partha
no flags Details
git-am fix for master and 4.0.x (1.19 KB, patch)
2013-06-07 23:32 UTC, Jeremy Allison
jra: review? (rsharpe)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Partha 2013-06-05 21:17:48 UTC
Issue description: I was trying to add maximum number of aces on Microsoft share, where I was able to add nearly 1800 aces on a file/folder SD. But Samba does not support adding 1800 aces to SD instead it limited to 1000. 

Expected behavior: Ideally SAMBA should also support as like Windows to compare with Windows standard.

Note: Samba do have SD size of 64kb which can easily accommodate 1800 aces.
Comment 1 Partha 2013-06-05 21:39:23 UTC
Created attachment 8947 [details]
attached the patch for supporting maximum number of aces limit in SAMBA

attached the patch for supporting maximum number of aces limit in SAMBA. Please do review and let me know any further changes required
Comment 2 Partha 2013-06-05 21:43:19 UTC
Test result: With the fix I have tested SAMBA and its able to accommodate/set 1800 aces on the 64kb size xattr. through smb2 setinfo and able to fetch them through smb2 getinfo.
Comment 3 Richard Sharpe 2013-06-06 04:59:32 UTC
Comment on attachment 8947 [details]
attached the patch for supporting maximum number of aces limit in SAMBA

Fixed the mime type.
Comment 4 Richard Sharpe 2013-06-06 05:02:58 UTC
Hi Partha,

Can you submit the patch as a git format-patch patch with a proper Signed-Off-By line.

You will need to git clone the Samba repos if you haven't already done that, and then you will need to git add the file you have modified and git commit. 

I can show you the steps tomorrow if you are not familiar with them.

Since 1,000 produces an SD much larger than 4,096 bytes (the limit of XATTRs on some platforms, I can't see any problems with this patch.

Probably the VFS should return an appropriate error if an SD is too large for it.
Comment 5 Jeremy Allison 2013-06-06 23:53:32 UTC
Having a signed-off-by git patch would be nice, but probably isn't necessary for this small a change.

It looks good to me - Richard I'll post it to the samba-technical list and if you can review it we'll get it into master, then into 4.0.next.

Cheers,

Jeremy.
Comment 6 Jeremy Allison 2013-06-07 23:32:41 UTC
Created attachment 8949 [details]
git-am fix for master and 4.0.x

git-am version of the patch I've submitted to samba-technical.

Jeremy.