Bug 9931 - pytalloc is GPL licensed instead of LGPL like the rest of talloc.
Summary: pytalloc is GPL licensed instead of LGPL like the rest of talloc.
Status: NEEDINFO
Alias: None
Product: TALLOC
Classification: Unclassified
Component: libtalloc (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal
Target Milestone: ---
Assignee: David Disseldorp
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-05 13:39 UTC by David Disseldorp
Modified: 2020-11-17 23:42 UTC (History)
14 users (show)

See Also:


Attachments
proposed patch (5.51 KB, patch)
2013-06-05 14:00 UTC, David Disseldorp
jelmer: review+
bjacke: review+
dbagnall: review+
metze: review+
Details
patch v2 with signed-off-by, BUG:, etc (6.15 KB, patch)
2020-11-02 19:17 UTC, Douglas Bagnall
ddiss: review+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Disseldorp 2013-06-05 13:39:47 UTC
The following files are impacted:
lib/talloc/pytalloc.c
lib/talloc/pytalloc.h
lib/talloc/pytalloc_util.c

Jelmer, is the GPL license intentional in this case?

In order to change the pytalloc license to LGPL, the following developers would need to agree:
Jelmer Vernooij <jelmer@samba.org>
Andrew Tridgell <tridge@samba.org>
Stefan Metzmacher <metze@samba.org>
Comment 1 Stefan Metzmacher 2013-06-05 13:45:00 UTC
(In reply to comment #0)
> The following files are impacted:
> lib/talloc/pytalloc.c
> lib/talloc/pytalloc.h
> lib/talloc/pytalloc_util.c
> 
> Jelmer, is the GPL license intentional in this case?
> 
> In order to change the pytalloc license to LGPL, the following developers would
> need to agree:
> Jelmer Vernooij <jelmer@samba.org>
> Andrew Tridgell <tridge@samba.org>
> Stefan Metzmacher <metze@samba.org>

Would be ok for me...

What about the others python bindings of tdb, tevent, ldb?
Comment 2 David Disseldorp 2013-06-05 13:48:56 UTC
(In reply to comment #1)
...
> > In order to change the pytalloc license to LGPL, the following developers would
> > need to agree:
> > Jelmer Vernooij <jelmer@samba.org>
> > Andrew Tridgell <tridge@samba.org>
> > Stefan Metzmacher <metze@samba.org>
> 
> Would be ok for me...

Thanks.


> What about the others python bindings of tdb, tevent, ldb?

pytdb.c, pytevent.c and pyldb.c are all LGPL.
Comment 3 David Disseldorp 2013-06-05 14:00:19 UTC
Created attachment 8945 [details]
proposed patch
Comment 4 Jelmer Vernooij 2013-08-13 11:56:56 UTC
I'm happy to see my pytalloc work relicensed as LGPLv3 or later.
Comment 5 Douglas Bagnall 2020-10-22 02:31:37 UTC
We are going backwards on this one.


Author: Andrew Bartlett <abartlet@samba.org>
Author: Andrew Tridgell <tridge@samba.org>
Author: Björn Jacke <bj@sernet.de>
Author: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>        *
Author: Garming Sam <garming@catalyst.net.nz>
Author: Gary Lockyer <gary@catalyst.net.nz>
Author: Jelmer Vernooij <jelmer@samba.org>                       *
Author: Kamen Mazdrashki <kamenim@samba.org>
Author: Kristján Valur <kristjan@rvx.is>
Author: Lukas Slebodnik <lslebodn@redhat.com>
Author: Noel Power <noel.power@suse.com>
Author: Petr Viktorin <pviktori@redhat.com>
Author: Stefan Metzmacher <metze@samba.org>                      *
Author: Timur I. Bakeyev <timur@iXsystems.com>


For my part, I am happy to see pytalloc relicensed as LGPLv3.

The authors marked with asterisks above have indicated consent in the comments here.
Comment 6 Gary Lockyer 2020-10-22 02:36:04 UTC
I'm also ok with pytalloc being relicensed as LGPLv3.
Comment 7 Andrew Bartlett 2020-10-23 18:16:12 UTC
Fine by me, I'm happy for pytalloc to be LGPLv3
Comment 8 Douglas Bagnall 2020-10-27 23:30:44 UTC
To the people just added to the CC list: 

Talloc is LGPL, while pytalloc is GPL. We want to regularise that by making pytalloc LGPL. (precisely, version 3 or greater in each case).

YOU are a pytalloc contributor (thank you!) so we need your assent.

See the proposed patch.
Comment 9 Lukas Slebodnik 2020-10-27 23:48:37 UTC
+1 for the change
Comment 10 Jelmer Vernooij 2020-10-28 00:49:14 UTC
I can't think of a good reason why pytalloc should be GPL rather than LGPL; it's almost certainly just oversight on my part. Maybe pytalloc started its live outside of lib/talloc, somewhere else in Samba and only made it in later? 

Either way, +1 on making it LGPL.
Comment 11 Jelmer Vernooij 2020-10-28 01:05:48 UTC
Ehr, life.
Comment 12 Jeremy Allison 2020-10-28 01:12:58 UTC
Just FYI - anyone who signed the Samba (C) statement here:

https://www.samba.org/samba/devel/copyright-policy.html

already implicitly gave consent to re-license under LGPLv3.
Comment 13 Noel Power 2020-10-28 07:59:15 UTC
also fine for me for lgpl
Comment 14 Douglas Bagnall 2020-10-28 22:07:33 UTC
As kristjan@rvx.is is no longer a valid email address (and hence the bugzilla account has disappeared), I contacted Kristján Valur Jónsson using the email address on the gitlab account from which we got the patches. He replied with:

> I approve of the proposed licencing change of Pytalloc. 
> Kristján Valur Jónsson, formerly kristjan@rvx.is
Comment 15 Garming Sam 2020-10-29 03:42:40 UTC
Fine by me.
Comment 16 Petr Viktorin 2020-10-29 08:22:13 UTC
+1 from me.
Comment 17 Douglas Bagnall 2020-10-29 19:15:10 UTC
(In reply to Jelmer Vernooij from comment #10)
> Maybe pytalloc started its live outside of lib/talloc, somewhere else in Samba and only made it in later? 

Yep. It was source4/scripting/python/pytalloc.[ch] until commit 0f043c197c473c801fc32c727194b5a2d6ae232f ("Move pytalloc to talloc directory.", October 2008).
Comment 18 Douglas Bagnall 2020-10-29 19:23:22 UTC
(In reply to Jeremy Allison from comment #12)

> Just FYI - anyone who signed the Samba (C) statement here:
>
> https://www.samba.org/samba/devel/copyright-policy.html
>
> already implicitly gave consent to re-license under LGPLv3.

Thanks. I'm trying to get explicit consent also, because it seems possible and better. And I'm not sure that all of the remaining three will have signed the policy.
Comment 19 Timur Bakeyev 2020-10-30 00:01:48 UTC
If you need my blessing - here it is :)
Comment 20 Douglas Bagnall 2020-11-02 18:45:12 UTC
via email:

On 2/11/20 10:22 am, Andrew Tridgell wrote:
> Hi Douglas,
> 
>> You contributed quite a bit to the Python bindings. Do you mind if we
>> relicense as LGPL?
> that is OK by me.
> 
> Cheers, Tridge
Comment 21 Douglas Bagnall 2020-11-02 19:17:50 UTC
Created attachment 16321 [details]
patch v2 with signed-off-by, BUG:, etc

Our patch conventions have changed. I've added a new version with:

* Signed-off-by David Disseldorp
* Reviewed-by all those who clicked the bugzilla review thing
* BUG: line

and not as a purely procedural thing, but because the information is on hand:

* a note based on comment #17, explaining how this came about.
Comment 22 David Disseldorp 2020-11-03 00:48:21 UTC
Comment on attachment 16321 [details]
patch v2 with signed-off-by, BUG:, etc

Looks fine to me, Douglas. I'd also be fine if you used your authorship, given that you've done all the hard work to track down and get these acks.
Comment 23 Douglas Bagnall 2020-11-17 22:31:25 UTC
The one author we haven't heard from added c0b9526aaf29442f85f62232e22aecfb484b1576 and 76a8ae9e0db0340bfa96c428d55afe9b885977e0.

According to git blame, these lines are gone, but when you look at the code, the essence of each commit remains (that is, talloc_unlink() and a char* cast, respectively).

I am not sure how to proceed here. Jeremy, did Kamen sign the copyright thing?
Comment 24 Jeremy Allison 2020-11-17 22:35:38 UTC
I don't have a record of his signing, but he has a @samba.org address, which means I don't think there's a conflict in org goals here.
Comment 25 Douglas Bagnall 2020-11-17 22:48:10 UTC
(In reply to David Disseldorp from comment #22)
David: you keep authorship!

And since you are the author, are you able to work out if/how we add WHATSNEW entries for libtalloc releases?
Comment 26 David Disseldorp 2020-11-17 23:42:23 UTC
(In reply to Douglas Bagnall from comment #25)
> (In reply to David Disseldorp from comment #22)
> David: you keep authorship!
> 
> And since you are the author, are you able to work out if/how we add
> WHATSNEW entries for libtalloc releases?

IIUC, talloc "release notes" normally just get listed in the tagged release commit.