Bug 9914 - Code generated from IDL could produce more informative error messages
Code generated from IDL could produce more informative error messages
Status: NEW
Product: Samba 4.0
Classification: Unclassified
Component: DCE-RPCs and pipes
unspecified
All All
: P5 normal
: ---
Assigned To: Andrew Bartlett
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-29 04:14 UTC by Richard Sharpe
Modified: 2013-05-29 04:14 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Sharpe 2013-05-29 04:14:21 UTC
I am not sure if this is fixed in master, but I noticed this in
pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm:

sub ParseArrayPullGetSize($$$$$$)
...
        $self->pidl("size_$e->{NAME}_$l->{LEVEL_INDEX} = $size;");
        my $array_size = "size_$e->{NAME}_$l->{LEVEL_INDEX}";

        if (my $range = has_property($e, "range")) {
                my ($low, $high) = split(/,/, $range, 2);
...
                $self->pidl("\treturn ndr_pull_error($ndr,
NDR_ERR_RANGE, \"value out of range\");");

It would be nice if this last had something like:

   \"value %u out of range $low..$high\", $array_size

Giving us more informative error messages is useful. It seems that the
range property appears in lots of places, so it would be nice if there
was more info on a failure to parse a field that had a range
attribute.