Bug 9891 - Fix calling nm(1) on OpenBSD
Fix calling nm(1) on OpenBSD
Status: RESOLVED WORKSFORME
Product: Samba 4.0
Classification: Unclassified
Component: Build
4.0.5
All All
: P5 normal
: ---
Assigned To: Björn Jacke
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-16 13:17 UTC by Vadim Zhukov
Modified: 2015-09-29 07:23 UTC (History)
1 user (show)

See Also:


Attachments
Patch to fix issue (558 bytes, patch)
2013-05-16 13:17 UTC, Vadim Zhukov
no flags Details
Patch to fix issue via git format-patch (991 bytes, patch)
2013-05-17 08:47 UTC, Vadim Zhukov
bjacke: review-
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Vadim Zhukov 2013-05-16 13:17:53 UTC
Created attachment 8893 [details]
Patch to fix issue

OpenBSD's nm(1) does not have -D option, and it defaults to equivalent behavior.

An alternative also could be using the objdump(1), but I'm not sure if it's more portable.
Comment 1 Vadim Zhukov 2013-05-17 08:47:52 UTC
Created attachment 8900 [details]
Patch to fix issue via git format-patch
Comment 2 Björn Jacke 2013-05-17 12:50:10 UTC
Comment on attachment 8900 [details]
Patch to fix issue via git format-patch

like in other places I think it would be better wo test how the "nm" binary behaves instead of just looking at the os version string. Probably it is also possible to use a "nm" on openbsd which has other options and also it is possible to have the openbsd like "nm" on other operatin systems. This is why we should check how "nm" behaves.
Comment 3 Jérémie Courrèges-Anglas 2015-09-01 18:53:21 UTC
nm(1) on OpenBSD grew a -D option on 2015/05/17.
Comment 4 Jérémie Courrèges-Anglas 2015-09-28 23:32:54 UTC
Vadim had introduced a similar patch in the OpenBSD net/samba port. Since our nm(1) supports the -D flag, I have removed this patch.

I don't think that keeping this issue opened is worth it, as far as OpenBSD is concerned.
Comment 5 Björn Jacke 2015-09-29 07:23:42 UTC
okay, as Samba is becoming slowly more usable on OpenBSD it's not worth fixing this for past releases.

We're still waiting for the NGROUPS_MAX limitation on OpenBSD to disappear ...