Bug 9889 - Fix potential overflow problems when formatting some types
Fix potential overflow problems when formatting some types
Status: NEW
Product: Samba 4.0
Classification: Unclassified
Component: Other
4.0.5
All All
: P5 normal
: ---
Assigned To: Andrew Bartlett
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-16 12:53 UTC by Vadim Zhukov
Modified: 2016-04-15 15:56 UTC (History)
1 user (show)

See Also:


Attachments
Patch to fix issues (5.00 KB, patch)
2013-05-16 12:53 UTC, Vadim Zhukov
no flags Details
Patch to fix issue via git format-patch (6.10 KB, patch)
2013-05-17 08:38 UTC, Vadim Zhukov
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Vadim Zhukov 2013-05-16 12:53:27 UTC
Created attachment 8891 [details]
Patch to fix issues

Some system "pseudo" types, like time_t, are mapped to different "real" types on different platforms. Even more, those "real" types could have different size, too. For example, "long" is 64-bit on Linux/x86-64 but 32-bit on OpenBSD/amd64. So a few formatting nits are seen only on some platforms.

Thanks to strict compilation rules of Samba4, those were noted on OpenBSD during compilation.

Probably I choosed a wrong component to report bug for - in that case I'm sorrt. Please feel free to correct me.
Comment 1 Vadim Zhukov 2013-05-16 12:55:47 UTC
I should also note, that OpenBSD is going to switch time_t and some other "system" types to "long long" or "unsigned long long" (read: 64-bit signed or unsigned) "real" types soon, so this is also a proactive measure.
Comment 2 Andrew Bartlett 2013-05-16 21:22:15 UTC
Can I get these as a git format-patch ?

(Otherwise I'll do it tomorrow, but this way you can set the authorship and commit message correctly)
Comment 3 Andrew Bartlett 2013-05-16 21:22:48 UTC
Can I get these as a git format-patch ?

(Otherwise I'll do it tomorrow, but this way you can set the authorship and
commit message correctly)
Comment 4 Vadim Zhukov 2013-05-17 08:38:53 UTC
Created attachment 8898 [details]
Patch to fix issue via git format-patch
Comment 5 Jérémie Courrèges-Anglas 2016-04-15 15:56:15 UTC
Those issues have been fixed by Volker in 13015a and a7b6dd4. I think this bug can be closed.