Created attachment 8890 [details] Patch to fix issue In a few places, the build infrastructure checks if it is running under OpenBSD. Unfortunately, it does a bad thing, comparing with either "openbsd4" or "openbsd5" (or both). OpenBSD versioning is different from many other projects, and, say, 5.0 does not differ from 4.9 more than from 5.1. So the right approach will be to check that platform name starts with "openbsd" instead. This is also the thing OpenBSD developers do when patching other software, so this patch is consistent with already existing practicies.
this looks not right to me: - if sys.platform != "openbsd4": + if sys.platform.startswith("openbsd"):
Created attachment 8895 [details] Patch to fix issue Sorry, missed one of the sub-patches. Here is a new, full patch.
(In reply to comment #1) > this looks not right to me: > > - if sys.platform != "openbsd4": > + if sys.platform.startswith("openbsd"): Oops, will fix ASAP.
Created attachment 8896 [details] Revision with fixed logic Here is a new version, now with fixed logic. I'm not sure that this problematic chunk should be keeped here, either, but I cannot test on GCC2 and/or GCC3 OpenBSD architectures to make this clear. I will fill another issue if I get more info regarding -Wl,--as-needed, okay?
Created attachment 8899 [details] Patch to fix issue via git format-patch
Created attachment 8907 [details] cherry-pick for 4.0 fixed in master with 2fda6c47f4aa46dbb42028732207a94821881c67. 4.0 patch attached. Lars, please review+ and reassign to Karo if okay ...
Comment on attachment 8907 [details] cherry-pick for 4.0 Looks ok as discussed some days back.
Passing to Karo for further processing.
Pushed to autobuild-v4-0-test.
Pushed to v4-0-test. Closing out bug report. Thanks!