Bug 9885 - Bogus #include <readline/history.h> in source4/torture/smbtorture.c
Summary: Bogus #include <readline/history.h> in source4/torture/smbtorture.c
Status: NEW
Alias: None
Product: Samba 4.0
Classification: Unclassified
Component: smbtorture (show other bugs)
Version: 4.0.5
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Andrew Bartlett
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-16 12:23 UTC by Vadim Zhukov
Modified: 2015-09-29 21:30 UTC (History)
0 users

See Also:

Attachments
Patch to fix issue (580 bytes, patch)
2013-05-16 12:23 UTC, Vadim Zhukov 		no flags Details
Patch to fix issue via git format-patch (972 bytes, patch)
2013-05-17 08:35 UTC, Vadim Zhukov 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vadim Zhukov 2013-05-16 12:23:50 UTC 
Created attachment 8886 [details]
Patch to fix issue

There is a preprocessor block at the line 37 in smbtorture.c:

#if HAVE_READLINE_HISTORY_H
#include <readline/history.h>
#endif

The whole block is not needed, because

#include "system/readline.h"

above already takes care of libreadline history support (using the same mechanism), and this #include breaks the build on OpenBSD when GNU readline package is installed (under /usr/local), because there is also libreadline in the base system (/usr).
Comment 1 Andrew Bartlett 2013-05-16 21:26:24 UTC 
Can I get these as a git format-patch ?

(Otherwise I'll do it tomorrow, but this way you can set the authorship and
commit message correctly)
Comment 2 Vadim Zhukov 2013-05-17 08:35:23 UTC 
Created attachment 8897 [details]
Patch to fix issue via git format-patch
Comment 3 Jérémie Courrèges-Anglas 2015-09-29 21:30:39 UTC 
Vadim's patch still applies on top of master.