Bug 9884 - days until password expires wrong in leap years?
Summary: days until password expires wrong in leap years?
Status: NEW
Alias: None
Product: Samba 4.0
Classification: Unclassified
Component: Winbind (show other bugs)
Version: 4.0.5
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Samba QA Contact
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-16 00:38 UTC by rusty
Modified: 2013-05-16 00:38 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description rusty 2013-05-16 00:38:37 UTC 
In nsswitch/pam_winbind.c, I believe the following code is off by 1 if the current date is in a leap year after leap day, and the password expires beyond the end of the current year.

        days = (tm_next_change.tm_yday+tm_next_change.tm_year*365) -
               (tm_now.tm_yday+tm_now.tm_year*365);

For instance, if it is 12/30/12 and the password expires on 1/30/13 (which is 31 days), this calculation computes as follows:
(29+113*365)-(364+112*365)=30

This assumes the leap year has 365 days, but the Julian day will be 1 higher than it is in non-leap years.  This in effect will subtract 1 too many days, thus indicating 1 fewer day than in actuality.

I believe this code is in previous versions as well, such as 3.6.9.