From Metze's commit message: /var/lock/samba is located on tmpfs on newer systems, but we want to keep things like the server affinity cache across reboots.
Created attachment 8777 [details] Proposed patch written by Metze
Created attachment 8778 [details] Proposed patch written by Metze incl. cherry-pick information
Comment on attachment 8778 [details] Proposed patch written by Metze incl. cherry-pick information Looks good
Comment on attachment 8778 [details] Proposed patch written by Metze incl. cherry-pick information Is this really something for a minor release? I certainly see this as very worthwhile for 4.1, but within the 4.0 release stream -- I don't know.
The patch should be pushed to v4-0-test a least as soon as possible.
Comment on attachment 8778 [details] Proposed patch written by Metze incl. cherry-pick information I think we do need this for 4.0, since putting the gencache.tdb into a tmpfs, hence losing it across reboots, can create very bad behaviour, e.g. after joins.
==> Karolin for 4.0.NEXT
(In reply to comment #5) > The patch should be pushed to v4-0-test a least as soon as possible. This is a typo, I meant v4-1-test here. Volker, are there any arguments against putting it into v4-0-test, also?
(In reply to comment #8) > (In reply to comment #5) > > The patch should be pushed to v4-0-test a least as soon as possible. > > This is a typo, I meant v4-1-test here. > > Volker, are there any arguments against putting it into v4-0-test, also? Okay, (In reply to comment #8) > (In reply to comment #5) > > The patch should be pushed to v4-0-test a least as soon as possible. > > This is a typo, I meant v4-1-test here. > > Volker, are there any arguments against putting it into v4-0-test, also? Okay, trying to sum up the issue: -Currently, the gencache.tdb incl. the server affinity cache is lost after reboot, because it's located on a tmpfs. -The patch would fix this issue, but might cause trouble on setups running very long without reboots. -> Adding the patch for 4.1 and mentioning in the release notes that you need to move the gencache.tdb after stopping the service is certainly ok. -> Is it ok for 4.0, also? Opinions? Karolin
Patch already in v4-1-test (54529fd3542).
(In reply to comment #9) > (In reply to comment #8) > > (In reply to comment #5) > > > The patch should be pushed to v4-0-test a least as soon as possible. > > > > This is a typo, I meant v4-1-test here. > > > > Volker, are there any arguments against putting it into v4-0-test, also? > > Okay, (In reply to comment #8) > > (In reply to comment #5) > > > The patch should be pushed to v4-0-test a least as soon as possible. > > > > This is a typo, I meant v4-1-test here. > > > > Volker, are there any arguments against putting it into v4-0-test, also? > > Okay, trying to sum up the issue: > -Currently, the gencache.tdb incl. the server affinity cache is lost after > reboot, because it's located on a tmpfs. > -The patch would fix this issue, but might cause trouble on setups running very > long without reboots. > > -> Adding the patch for 4.1 and mentioning in the release notes that you need > to > move the gencache.tdb after stopping the service is certainly ok. > -> Is it ok for 4.0, also? > > Opinions? > > Karolin Pushed to v4-0-test after talking to obnox and metze. Please feel free to re-open/revert the patch.