Bug 9784 - classicupgrade: Improve handling of invalid accounts (particularly from pdb_ldap)
classicupgrade: Improve handling of invalid accounts (particularly from pdb_l...
Status: NEW
Product: Samba 4.0
Classification: Unclassified
Component: AD: LDB/DSDB/SAMDB
4.0.5
All All
: P5 normal
: ---
Assigned To: Andrew Bartlett
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-10 23:36 UTC by Andrew Bartlett
Modified: 2013-05-12 07:05 UTC (History)
2 users (show)

See Also:


Attachments
proposed, but untested patch to fix this in master (2.51 KB, patch)
2013-04-10 23:36 UTC, Andrew Bartlett
no flags Details
improved patch (3.91 KB, patch)
2013-04-11 02:45 UTC, Andrew Bartlett
no flags Details
patch for pdb_ldap NOT to skip invalid account (1.34 KB, patch)
2013-04-11 07:21 UTC, Andrew Bartlett
no flags Details
Attempt to make the 30,000 user upgrade faster (6.64 KB, patch)
2013-04-14 04:37 UTC, Andrew Bartlett
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Bartlett 2013-04-10 23:36:45 UTC
Created attachment 8754 [details]
proposed, but untested patch to fix this in master

This patch helps us skip some more invalid accounts in the classicupgrade code.
Comment 1 Andrew Bartlett 2013-04-11 02:45:38 UTC
Created attachment 8756 [details]
improved patch
Comment 2 Andrew Bartlett 2013-04-11 07:21:40 UTC
Created attachment 8757 [details]
patch for pdb_ldap NOT to skip invalid account

In this case, we want this invalid account to show up, so we can fix it, rather than skip it, but do so at the python later, not deep in passdb.
Comment 3 Andrew Bartlett 2013-04-14 04:37:34 UTC
Created attachment 8769 [details]
Attempt to make the 30,000 user upgrade faster

This patch tries to make a 30,000 user upgrade faster, by using transactions over adding the users, adding the groups and then adding the memberships.
Comment 4 Andrew Bartlett 2013-05-12 07:05:14 UTC
I'm still waiting for feedback before proposing this patch for master.