Bug 9527 - reindexing is triggered twice per partition when modifying @ATTRIBUTE in sam.ldb
Summary: reindexing is triggered twice per partition when modifying @ATTRIBUTE in sam.ldb
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: AD: LDB/DSDB/SAMDB (show other bugs)
Version: 4.7.0rc5
Hardware: All All
: P5 minor (vote)
Target Milestone: 4.7
Assignee: Andrew Bartlett
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-02 02:41 UTC by Matthieu Patou
Modified: 2019-06-11 21:29 UTC (History)
4 users (show)

See Also:

Attachments
possible patch for master (3.05 KB, patch)
2017-09-11 01:59 UTC, Andrew Bartlett 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthieu Patou 2013-01-02 02:41:07 UTC 
I introduced some code to debug the reindexing: 

[5/6 in 1m28s] samba4.ldap_schema.python(fl2003dc)
Reindexing /usr/local/src/samba/st/fl2003dc/private/sam.ldb due to modification on @ATTRIBUTES
Reindexing /usr/local/src/samba/st/fl2003dc/private/sam.ldb.d/CN=SCHEMA,CN=CONFIGURATION,DC=SAMBA2003,DC=EXAMPLE,DC=COM.ldb due to modification on @ATTRIBUTES
Reindexing /usr/local/src/samba/st/fl2003dc/private/sam.ldb.d/CN=CONFIGURATION,DC=SAMBA2003,DC=EXAMPLE,DC=COM.ldb due to modification on @ATTRIBUTES
Reindexing /usr/local/src/samba/st/fl2003dc/private/sam.ldb.d/DC=DOMAINDNSZONES,DC=SAMBA2003,DC=EXAMPLE,DC=COM.ldb due to modification on @ATTRIBUTES
Reindexing /usr/local/src/samba/st/fl2003dc/private/sam.ldb.d/DC=FORESTDNSZONES,DC=SAMBA2003,DC=EXAMPLE,DC=COM.ldb due to modification on @ATTRIBUTES
Reindexing /usr/local/src/samba/st/fl2003dc/private/sam.ldb.d/DC=SAMBA2003,DC=EXAMPLE,DC=COM.ldb due to modification on @ATTRIBUTES
Reindexing /usr/local/src/samba/st/fl2003dc/private/sam.ldb.d/CN=SCHEMA,CN=CONFIGURATION,DC=SAMBA2003,DC=EXAMPLE,DC=COM.ldb due to modification on @ATTRIBUTES
Reindexing /usr/local/src/samba/st/fl2003dc/private/sam.ldb.d/CN=CONFIGURATION,DC=SAMBA2003,DC=EXAMPLE,DC=COM.ldb due to modification on @ATTRIBUTES
Reindexing /usr/local/src/samba/st/fl2003dc/private/sam.ldb.d/DC=DOMAINDNSZONES,DC=SAMBA2003,DC=EXAMPLE,DC=COM.ldb due to modification on @ATTRIBUTES
Reindexing /usr/local/src/samba/st/fl2003dc/private/sam.ldb.d/DC=FORESTDNSZONES,DC=SAMBA2003,DC=EXAMPLE,DC=COM.ldb due to modification on @ATTRIBUTES
Reindexing /usr/local/src/samba/st/fl2003dc/private/sam.ldb.d/DC=SAMBA2003,DC=EXAMPLE,DC=COM.ldb due to modification on @ATTRIBUTES


Reindexing /usr/local/src/samba/st/fl2003dc/private/sam.ldb due to modification on @ATTRIBUTES
Reindexing /usr/local/src/samba/st/fl2003dc/private/sam.ldb.d/CN=SCHEMA,CN=CONFIGURATION,DC=SAMBA2003,DC=EXAMPLE,DC=COM.ldb due to modification on @ATTRIBUTES
Reindexing /usr/local/src/samba/st/fl2003dc/private/sam.ldb.d/CN=CONFIGURATION,DC=SAMBA2003,DC=EXAMPLE,DC=COM.ldb due to modification on @ATTRIBUTES
Reindexing /usr/local/src/samba/st/fl2003dc/private/sam.ldb.d/DC=DOMAINDNSZONES,DC=SAMBA2003,DC=EXAMPLE,DC=COM.ldb due to modification on @ATTRIBUTES
Reindexing /usr/local/src/samba/st/fl2003dc/private/sam.ldb.d/DC=FORESTDNSZONES,DC=SAMBA2003,DC=EXAMPLE,DC=COM.ldb due to modification on @ATTRIBUTES
Reindexing /usr/local/src/samba/st/fl2003dc/private/sam.ldb.d/DC=SAMBA2003,DC=EXAMPLE,DC=COM.ldb due to modification on @ATTRIBUTES
Reindexing /usr/local/src/samba/st/fl2003dc/private/sam.ldb.d/CN=SCHEMA,CN=CONFIGURATION,DC=SAMBA2003,DC=EXAMPLE,DC=COM.ldb due to modification on @ATTRIBUTES
Reindexing /usr/local/src/samba/st/fl2003dc/private/sam.ldb.d/CN=CONFIGURATION,DC=SAMBA2003,DC=EXAMPLE,DC=COM.ldb due to modification on @ATTRIBUTES
Reindexing /usr/local/src/samba/st/fl2003dc/private/sam.ldb.d/DC=DOMAINDNSZONES,DC=SAMBA2003,DC=EXAMPLE,DC=COM.ldb due to modification on @ATTRIBUTES
Reindexing /usr/local/src/samba/st/fl2003dc/private/sam.ldb.d/DC=FORESTDNSZONES,DC=SAMBA2003,DC=EXAMPLE,DC=COM.ldb due to modification on @ATTRIBUTES
Reindexing /usr/local/src/samba/st/fl2003dc/private/sam.ldb.d/DC=SAMBA2003,DC=EXAMPLE,DC=COM.ldb due to modification on @ATTRIBUTES


Reindexing /usr/local/src/samba/st/fl2003dc/private/sam.ldb due to modification on @ATTRIBUTES
Reindexing /usr/local/src/samba/st/fl2003dc/private/sam.ldb.d/CN=SCHEMA,CN=CONFIGURATION,DC=SAMBA2003,DC=EXAMPLE,DC=COM.ldb due to modification on @ATTRIBUTES
Reindexing /usr/local/src/samba/st/fl2003dc/private/sam.ldb.d/CN=CONFIGURATION,DC=SAMBA2003,DC=EXAMPLE,DC=COM.ldb due to modification on @ATTRIBUTES
Reindexing /usr/local/src/samba/st/fl2003dc/private/sam.ldb.d/DC=DOMAINDNSZONES,DC=SAMBA2003,DC=EXAMPLE,DC=COM.ldb due to modification on @ATTRIBUTES
Reindexing /usr/local/src/samba/st/fl2003dc/private/sam.ldb.d/DC=FORESTDNSZONES,DC=SAMBA2003,DC=EXAMPLE,DC=COM.ldb due to modification on @ATTRIBUTES
Reindexing /usr/local/src/samba/st/fl2003dc/private/sam.ldb.d/DC=SAMBA2003,DC=EXAMPLE,DC=COM.ldb due to modification on @ATTRIBUTES
Reindexing /usr/local/src/samba/st/fl2003dc/private/sam.ldb.d/CN=SCHEMA,CN=CONFIGURATION,DC=SAMBA2003,DC=EXAMPLE,DC=COM.ldb due to modification on @ATTRIBUTES
Reindexing /usr/local/src/samba/st/fl2003dc/private/sam.ldb.d/CN=CONFIGURATION,DC=SAMBA2003,DC=EXAMPLE,DC=COM.ldb due to modification on @ATTRIBUTES
Reindexing /usr/local/src/samba/st/fl2003dc/private/sam.ldb.d/DC=DOMAINDNSZONES,DC=SAMBA2003,DC=EXAMPLE,DC=COM.ldb due to modification on @ATTRIBUTES
Reindexing /usr/local/src/samba/st/fl2003dc/private/sam.ldb.d/DC=FORESTDNSZONES,DC=SAMBA2003,DC=EXAMPLE,DC=COM.ldb due to modification on @ATTRIBUTES
Reindexing /usr/local/src/samba/st/fl2003dc/private/sam.ldb.d/DC=SAMBA2003,DC=EXAMPLE,DC=COM.ldb due to modification on @ATTRIBUTES


As it can be witnessed a modification on ATTRIBUTES in sam.ldb trigger 2 reindexing per partition ...
Comment 1 Matthias Dieter Wallnöfer 2014-04-24 19:33:12 UTC 
This is nasty, but a bug with MINOR impact I think.
Comment 2 Andrew Bartlett 2017-09-11 01:59:21 UTC 
Created attachment 13568 [details]
possible patch for master
Comment 3 Andrew Bartlett 2019-06-11 21:29:33 UTC 
Fixed in Samba 4.8 by ee4418e73f5ed9a1c5d5dc1a5547899f80d9fb5a.

Also re-index is much, much faster in Samba 4.11 so this will matter even less.