Created attachment 8358 [details] configure and make full capture FreeBSD 8.3-STABLE amd64 configure Checking for stylesheet http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl : ok make ... [3782/3863] Generating manpages/smb.conf.5 I/O error : Attempt to load network entity http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl warning: failed to load external entity "http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl" compilation error: file /u/1/samba-4.0.0/docs-xml/xslt/man.xsl line 7 element import xsl:import : unable to load http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl Waf: Leaving directory `/u/1/samba-4.0.0/bin' Build failed: -> task failed (err #5): {task: manpages/smb.conf.5 smb.conf.5.xml -> smb.conf.5} *** Error code 1 Attachment is full output of configure and make commands
The build system can not load the docbook.xsl file from sourceforge.net. I/O error : Attempt to load network entity http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl warning: failed to load external entity Typically systems use a local rewrite of this url that refer to a locally stored file. On my Gentoo Linux I find this in /etc/xml/catalog with the referral to the /etc/xml/docbook file. This is the entry: <delegateURI uriStartString="http://docbook.sourceforge.net/release/xsl/" catalog="file:///etc/xml/docbook"/>
You replied: "Typically systems use a local rewrite of this url that refer to a locally stored file." I don't know what that means. The "configure" portion of the build indicated: Checking for stylesheet http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl : ok and I didn't see any indication in the log that there was something misconfigured. The "make" appears to be almost complete "[3782/3863]" before this error occurs. Any hint about where to look or what to look for would be greatly appreciated. System is FreeBSD...I have tried 8.3-RELEASE (32-bit and 64-bit) and 9.1-RELEASE (32-bit and 64-bit). If I am missing some required library or package, there wasn't any obvious indication in the configure/make log(s). Thanks for your assistance.
Your response prompted me to dig into the build process. It appears that every ./release-scripts/build-* has hard-coded a reference to "/etc/xml/catalog". In the FreeBSD world, the xml catalog is in "/usr/local/share/xml/catalog" (the docproj package installation default). Can the generation of ./release-scripts/build-* be changed to be aware of the operating system default destination for the xml catalog?
Created attachment 8361 [details] proposed fix Thank you for the information. I attached a patch to this bug. Could you try this?
(In reply to comment #3) > Can the generation of ./release-scripts/build-* be changed to be aware of the > operating system default destination for the xml catalog? Just for you information: the typical "make"-waf-build does not use the release scripts. These are optional scripts. My patch fixes only the waf build. I'll also fix the release scripts, if the proposed patch work.
(In reply to comment #4) > Created attachment 8361 [details] > proposed fix > > Thank you for the information. > > I attached a patch to this bug. Could you try this? The patch works for me. Thanks.
(In reply to comment #5) > (In reply to comment #3) > > Can the generation of ./release-scripts/build-* be changed to be aware of the > > operating system default destination for the xml catalog? > > Just for you information: the typical "make"-waf-build does not use the release > scripts. These are optional scripts. My patch fixes only the waf build. I'll > also fix the release scripts, if the proposed patch work. Thanks for the information. I haven't gotten into Samba4 workings yet and this prompted me to start. Thanks again.
(In reply to comment #4) > Created attachment 8361 [details] > proposed fix > > Thank you for the information. > > I attached a patch to this bug. Could you try this? Rather than testing on the OS, could you have the python code look in a few different locations, and use it if the directory (or the catalog we need) exists?
Created attachment 8363 [details] proposed fix 2 (In reply to comment #8) > Rather than testing on the OS, could you have the python code look in a few > different locations, and use it if the directory (or the catalog we need) > exists? You're right. But we do not need to check if the file exists or not. The system ignores non-existent files. Please see newly attached patch.
(In reply to comment #9) > Created attachment 8363 [details] > proposed fix 2 > > (In reply to comment #8) > > Rather than testing on the OS, could you have the python code look in a few > > different locations, and use it if the directory (or the catalog we need) > > exists? > > You're right. But we do not need to check if the file exists or not. The system > ignores non-existent files. > > Please see newly attached patch. The new patch works for me. Thanks.
Created attachment 8435 [details] proposed patch cherry-picked from master
Comment on attachment 8435 [details] proposed patch cherry-picked from master There is a reason I objected to this going into master at the time. You should *never* have a platform-specific if like this in core code such as the wafsamba.py file. You need to detect if that file exists, and then add it to the list of possible files we build with, not check for freebsd. The same will almost happen on DragonflyBSD, NetBSD, OpenBSD and any other platform build from source. Also I don't see the cherry-pick reference (if cherry-picking, use -x so we can track the git commit). I think this was just a mistake, as https://gitweb.samba.org/?p=samba.git;a=commitdiff;h=d61d2af3727a19cc4ddc88ec2faa8aafff9c7422 is much more reasonable.
Created attachment 8436 [details] now it is the proposed patch cherry-picked from master > I think this was just a mistake, as > https://gitweb.samba.org/?p=samba.git;a=commitdiff;h=d61d2af3727a19cc4ddc88ec2faa8aafff9c7422 > is much more reasonable. Oops, yes - wrong patch sorry! This was the old one. I attached the new patch, reviewed by obnox, vl and tested by the reporter.
Comment on attachment 8436 [details] now it is the proposed patch cherry-picked from master ACK
==> Karolin for inclusion.
Pushed to autobuild-v4-0-test.
Pushed to v4-0-test. Closing out bug report. Thanks!