Bug 9469 - creation of duplicate GROUP acl for owning group can fail
Summary: creation of duplicate GROUP acl for owning group can fail
Status: RESOLVED INVALID
Alias: None
Product: Samba 4.0
Classification: Unclassified
Component: File services (show other bugs)
Version: 4.0.0rc5
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Samba QA Contact
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-06 00:29 UTC by Michael Adam
Modified: 2012-12-06 09:21 UTC (History)
0 users

See Also:

Attachments
patch cherry-picked from master (1.09 KB, patch)
2012-12-06 00:29 UTC, Michael Adam 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Adam 2012-12-06 00:29:11 UTC 
There is a cut and paste error where the check is made against the user id and not against the group id when checking whether the duplicate entry already exists. Hence we can fail to create the entry, possibly creating permission problems when chnanging the group owner of the file/directory.
Comment 1 Michael Adam 2012-12-06 00:29:58 UTC 
Created attachment 8291 [details]
patch cherry-picked from master

This is the obvious fix from master. with cherry-pick-info
Comment 2 Michael Adam 2012-12-06 09:20:37 UTC 
OK. this was actually already fixed, but since the order of patches was reversed, I undid the patch in my patch for bug #9462. gonna fix that patchset...