The Samba-Bugzilla – Bug 9388
Compatibility with newer versions of system heimdal
Last modified: 2014-06-10 21:54:08 UTC
There are some slight changes in the Heimdal windc API that make cause Samba4 to break when used with newer versions of Heimdal. Samba 4 should be able to work with newer versions of Heimal, too.
See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=686227 for background.
Debian and Ubuntu build against the system heimdal, so this is a fairly big issue.
Jelmer, are commits da284b3765e3c73d204fe2c8b45d6fbd2c08d451 and da284b3765e3c73d204fe2c8b45d6fbd2c08d451^ related to this?
(In reply to comment #2)
> Jelmer, are commits da284b3765e3c73d204fe2c8b45d6fbd2c08d451 and
> da284b3765e3c73d204fe2c8b45d6fbd2c08d451^ related to this?
Not really, only so much in that the first is also related to building with the system Heimdal.
da284b3765e3c73d204fe2c8b45d6fbd2c08d451^ was just a minor cleanup.
da284b3765e3c73d204fe2c8b45d6fbd2c08d451 was a patch we've been carrying in the Debian/Ubuntu packages for a while that I decided to upstream. It's required for the basic chroot in which the packages get built, since there usually isn't a config.h around there.
Created attachment 8205 [details]
Patch for new heimdal API
this patch seems to solve the issue, adapting the samba_wdc_check_client_access function to the new heimdal API. I am not a heimdal developer so it would be great if someone can review it. At least it seems to work and samba doesn't crash any more.
(In reply to comment #4)
> Created attachment 8205 [details]
> Patch for new heimdal API
> this patch seems to solve the issue, adapting the samba_wdc_check_client_access
> function to the new heimdal API. I am not a heimdal developer so it would be
> great if someone can review it. At least it seems to work and samba doesn't
> crash any more.
Thanks for the patch, Samuel. We'll need some #ifdefs as Samba itself still includes an older copy of Heimdal without these changes, and we should still support building against older versions as well.
I'm not super familiar with this side of the code, but perhaps Andrew has some time to have a look..
undoing this a blocker bug, but...
Love (hope your bugzilla mail address is still valid), can you have a look at this? Also a great chance to play some more with samba again ;-)
Jelmer, the last messages in
indicate that this is fixed?
Can we close this bug?
I landed a patch for this, but it has some open issues which are currently being addressed on samba-technical@.