Bug 9376 - ensure_canon_entry_valid generates duplicate SMB_ACL_GROUP, acl_valid fails
ensure_canon_entry_valid generates duplicate SMB_ACL_GROUP, acl_valid fails
Status: RESOLVED FIXED
Product: Samba 4.0
Classification: Unclassified
Component: File services
4.0 beta4
All All
: P5 normal
: ---
Assigned To: Karolin Seeger
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-10 09:54 UTC by Arvid Requate
Modified: 2012-11-13 10:44 UTC (History)
0 users

See Also:


Attachments
Fix typo in the got_duplicate_group code (880 bytes, patch)
2012-11-10 09:56 UTC, Arvid Requate
no flags Details
git-am fix for 4.0.0.rc.next (1.24 KB, patch)
2012-11-10 17:25 UTC, Jeremy Allison
vl: review+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Arvid Requate 2012-11-10 09:54:47 UTC
Due to a typo in posix_acl.c:ensure_canon_entry_valid_on_set the function returns invalid ACLs in some cases. Specifically it genereates a SMB_ACL_GROUP for a SMB_ACL_GROUP_OBJ, where the required SMB_ACL_GROUP ace is already present. This can result in a failure of acl_valid in vfs_acl_xattr.
Comment 1 Arvid Requate 2012-11-10 09:56:22 UTC
Created attachment 8177 [details]
Fix typo in the got_duplicate_group code
Comment 2 Jeremy Allison 2012-11-10 17:25:36 UTC
Created attachment 8178 [details]
git-am fix for 4.0.0.rc.next
Comment 3 Jeremy Allison 2012-11-10 17:26:08 UTC
Original patch applies to master (I'll push) but not to 4.0.0.rc.next.

Jeremy.
Comment 4 Karolin Seeger 2012-11-13 08:50:04 UTC
Pushed to autobuild-v4-0-test.
Comment 5 Karolin Seeger 2012-11-13 10:44:03 UTC
Pushed to v4-0-test.
Closing out bug report.

Thanks!