amitay, can you attach the patch you did for dlz ? We need also my patch for the internal server.
Matthieu, I have pushed the two patches upstream. e65a24b59f1dc7d212a46014a1d7c2531263529f s4-rpc: dnsserver: Ignore DNS zones that are not used by RPC dnsserver d70f3644a485ef53e6173ef81326ba6f065f418a s4-dns: dlz_bind9: Ignore zones that are not used by BIND9 DLZ plugin
Created attachment 8013 [details] patch1
Created attachment 8014 [details] patch2
Matthieu, please find the patches to fix the problem reported in this defect for BIND DLZ module and dnsserver RPC module. patch1 is for dnsserver RPC module patch2 is for BIND DLZ module
Created attachment 8067 [details] replicate code change from dlz into internal dns server
Comment on attachment 8067 [details] replicate code change from dlz into internal dns server I'd still prefer if we explicitly explain why we don't support zones we're skipping in the code.
Created attachment 8068 [details] Updated version of the patch with comments
Comment on attachment 8068 [details] Updated version of the patch with comments Updated to take in accounts remarks of kai.
08:23 < ekacnet> as for the zones I think I explain why we don't do this 08:26 < kblin> I want this in the code 08:26 < kblin> this is a magic constant, and I'd like the explanation with the magic constant 08:26 < ekacnet> ok wasn't clear for me 08:27 < kblin> having to run git blame to figure out _why_ code does what it does sucks
Created attachment 8069 [details] Updated version of the patch with comments
Comment on attachment 8069 [details] Updated version of the patch with comments That looks much better, thanks. Now if you could just align the two strcmps to be below each other, it'd be perfect. :)
Also, the patch doesn't apply for me. :(
(In reply to comment #13) > Also, the patch doesn't apply for me. :( on master ? or about to samba-4.0 test ?
Created attachment 8071 [details] Rechecked patch + strcmp format fix Regenerated patch on top of d5c51e95ff8dbd4f5f50a7ea3f1d211194bb2809 with indentation fix Applied with git am <patch_name>
Comment on attachment 8071 [details] Rechecked patch + strcmp format fix Great, thanks alot
Comment on attachment 8069 [details] Updated version of the patch with comments Marking old patch obsolete
Karolin, please pick for rc3
Pushed to autobuild-v4-0-test. Closing out bug report. Thanks!
Karolin the three patches needed to be picked up, for next RC can you pick-up the two patches from amitay ?
Created attachment 8080 [details] [PATCH] bug 9265 s4-dns: dlz_bind9: Ignore zones that are not used by BIND9 DLZ plugin Bug: 9265, part 2 Signed-off-by: Amitay Isaacs <amitay@gmail.com> Signed-off-by: Matthieu Patou <mat@matws.net> --- source4/dns_server/dlz_bind9.c | 5 +++++ 1 file changed, 5 insertions(+)
Created attachment 8081 [details] [PATCH] bug 9265 s4-rpc: dnsserver: Ignore DNS zones that are not used by RPC dnsserver ..TrustAnchors zone is not interpreted by RPC dnsserver code. Bug: 9265, part 1 Signed-off-by: Amitay Isaacs <amitay@gmail.com> Autobuild-User(master): Amitay Isaacs <amitay@samba.org> Autobuild-Date(master): Tue Oct 9 03:21:07 CEST 2012 on sn-devel-104 Signed-off-by: Matthieu Patou <mat@matws.net> --- source4/rpc_server/dnsserver/dnsdb.c | 4 ++++ 1 file changed, 4 insertions(+)
Created attachment 8266 [details] Patch proposed by metze
Comment on attachment 8266 [details] Patch proposed by metze ACK
Comment on attachment 8014 [details] patch2 obsoleted by patchset with cherry-pick-info
==> Karolin for 4.0
Pushed to autobuild-v4-0-test.
Comment on attachment 8071 [details] Rechecked patch + strcmp format fix This patch is already in v4-0-test
Pushed to v4-0-test. Closing out bug report. Thanks!