Bug 9263 - input parameter validation is missing for UpdateRefs
Summary: input parameter validation is missing for UpdateRefs
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.0
Classification: Unclassified
Component: AD: LDB/DSDB/SAMDB (show other bugs)
Version: 4.0.0rc2
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Matthieu Patou
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-08 06:49 UTC by Matthieu Patou
Modified: 2021-01-18 10:27 UTC (History)
1 user (show)

See Also:

Attachments
Proposed patch to fix the problem (1.93 KB, patch)
2012-10-13 07:43 UTC, Matthieu Patou 		no flags Details
Good fix (1.31 KB, patch)
2012-10-13 07:52 UTC, Matthieu Patou 		abartlet: review+
Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthieu Patou 2012-10-08 06:49:16 UTC 

    


    


      



        
          Comment 1
        

        
          Matthieu Patou

        

        
        

        
          2012-10-13 07:43:24 UTC
        

      






Created attachment 8064 [details]
Proposed patch to fix the problem

    


    


      



        
          Comment 2
        

        
          Matthieu Patou

        

        
        

        
          2012-10-13 07:50:13 UTC
        

      






This patch check more throughly the validity of the NC

    


    


      



        
          Comment 3
        

        
          Matthieu Patou

        

        
        

        
          2012-10-13 07:52:43 UTC
        

      






Created attachment 8065 [details]
Good fix

    


    


      



        
          Comment 4
        

        
          Michael Adam

        

        
        

        
          2012-10-14 19:17:21 UTC
        

      






Assigning to Karolin for inclusion into v4-0-test.

    


    


      



        
          Comment 5
        

        
          Karolin Seeger

        

        
        

        
          2012-10-15 09:14:25 UTC
        

      






Patch does not apply to current v4-0-test.
Re-assigning to Matthieu.

    


    


      



        
          Comment 6
        

        
          Stefan Metzmacher

        

        
        

        
          2012-10-15 10:07:12 UTC
        

      






(In reply to comment #5)
> Patch does not apply to current v4-0-test.
> Re-assigning to Matthieu.

The problem is that is based on the patch from bug 9262
https://bugzilla.samba.org/attachment.cgi?id=8063&action=edit

    


    


      



        
          Comment 7
        

        
          Stefan Metzmacher

        

        
        

        
          2013-08-29 07:08:15 UTC
        

      






No 4.1 blocker => 4.2

    


    


      



        
          Comment 8
        

        
          Karolin Seeger

        

        
        

        
          2013-12-10 15:38:11 UTC
        

      






Any news on this one?

    


    


      



        
          Comment 9
        

        
          Stefan Metzmacher

        

        
        

        
          2019-10-23 07:52:17 UTC
        

      






Fixed as commit dc002a394b0e41254c061176f480b56a0ac4097d in samba-4.2.0rc1