Created attachment 8062 [details]
Proposed patch to fix the problem

Problem was that the idl for the string was incorrect a astring didn't represent data as it was on the wire.

The structure of drsuapi_DsReplicaSyncRequest1 is described in MS-DRSR.pdf 4.1.23.1.2 DRS_MSG_REPSYNC_V1:


typedef struct {
[ref] DSNAME* pNC;
UUID uuidDsaSrc;
[unique, string] char* pszDsaSrc;
ULONG ulOptions;
} DRS_MSG_REPSYNC_V1;

uuidDsaSrc: The DSA GUID.

pNC: A pointer to DSName of the root of an NC replica on the server.

The DRS_MSG_REPSYNC_V1 structure defines a request message sent to the
IDL_DRSReplicaSync method.

pszDsaSrc: The transport-specific NetworkAddress of a DC.

ulOptions: The DRS_OPTIONS flags.

Created attachment 8070 [details]
drsuapi_DsReplicaSync input structure as sent by the DRSR test driver.

Comment on attachment 8062 [details]
Proposed patch to fix the problem

Isn't it more likely the string is in UTF8 rather than DOS?

I'm still +1 on this as better than it was before (astring is also DOS), but please investigate for a future patch to master.

(In reply to comment #5)
> Comment on attachment 8062 [details]
> Proposed patch to fix the problem
> 
> Isn't it more likely the string is in UTF8 rather than DOS?
> 
> I'm still +1 on this as better than it was before (astring is also DOS), but
> please investigate for a future patch to master.

Is AD supporting domains with non ascii chars ? 
As the dns name is in fact the guid + _msdcs + domain name the only part of utf8 can be in the domain name.

UTF-8 as encoding seems more plausible to me too. Either way, I agree with Andrew that this is an improvement over the current situation. Thanks for working on this!

Karolin, please pick up for rc3.

Thanks

Comment on attachment 8062 [details]
Proposed patch to fix the problem

Looks good

Pushed to autobuild-v4-0-test.
Closing out bug report.

Thanks!