Bug 9251 - DsGetDomainControllerInfo returns objects of class server even if they don't have a serverreference
DsGetDomainControllerInfo returns objects of class server even if they don't ...
Status: NEW
Product: Samba 4.0
Classification: Unclassified
Component: DCE-RPCs and pipes
4.0.0rc2
All All
: P5 normal
: ---
Assigned To: Matthieu Patou
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-08 06:14 UTC by Matthieu Patou
Modified: 2012-10-17 06:21 UTC (History)
0 users

See Also:


Attachments
Fix the bug by adding more precises tests (1.62 KB, patch)
2012-10-13 06:39 UTC, Matthieu Patou
abartlet: review+
Details
[PATCH] bug 9251 getdcinfo: Check that the server object has a serverreference objects pointing to a DC object (1.12 KB, patch)
2012-10-17 05:41 UTC, Matthieu Patou
abartlet: review+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matthieu Patou 2012-10-08 06:14:55 UTC
According to DRSR entries of objectclass=server should be returned only if the serverreference attribute is present and points to a valid DC object.
Comment 1 Matthieu Patou 2012-10-13 06:39:17 UTC
Created attachment 8051 [details]
Fix the bug by adding more precises tests
Comment 2 Matthieu Patou 2012-10-14 21:07:22 UTC
Karolin, please pick up for rc3.

Thanks
Comment 3 Karolin Seeger 2012-10-15 08:50:29 UTC
Patch does not apply.
Re-assigning to Matthieu.
Comment 4 Matthieu Patou 2012-10-17 04:49:41 UTC
The line "ret = ldb_search(b_state->sam_ctx, mem_ctx, &res_account, ref_dn, " lacks a space at the beginning given the fact that I got the patch from git format-patch 3dd2b804b98e232bf9f28a29577f7fdd026a228c -1
I don't really understand how it has occurred.
Comment 5 Matthieu Patou 2012-10-17 05:41:02 UTC
Created attachment 8079 [details]
[PATCH] bug 9251 getdcinfo: Check that the server object has a serverreference objects pointing to a DC object


The problem was found by the DRSR testsuite where server objects were
created in the Site container without serverrefrence attribute
triggering error in the testsuite.

Bug: 9251
---
 source4/rpc_server/drsuapi/dcesrv_drsuapi.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Comment 6 Matthieu Patou 2012-10-17 05:42:53 UTC
Generated with git format-patch on top of fa4b3c953c1addcac75ddea2d1a50b38d43fb668