Bug 924 - smbtorture returns true even an invalid test name is provided
smbtorture returns true even an invalid test name is provided
Product: Samba 3.0
Classification: Unclassified
Component: Client Tools
All All
: P3 normal
: none
Assigned To: Tim Potter
Depends on:
  Show dependency treegraph
Reported: 2003-12-26 02:11 UTC by Shiro Yamada
Modified: 2005-08-24 10:18 UTC (History)
1 user (show)

See Also:

a proposed patch for this bug (1016 bytes, patch)
2003-12-26 02:12 UTC, Shiro Yamada
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Shiro Yamada 2003-12-26 02:11:45 UTC
I couldn't find a right category for smbtorture so I am posing here, forgive
me if I shouldn't have. 

Currently, under smbtorture in Samba 3.0, there is no routine to check the
validity of test names. In another word, even when a non-existing test is
specified by a user, smbtorture returns true without doing anything.
Some kind of verification is needed to make sure test name provided is the
valid one.

Also, the condition for executing ALL tests needs to be fixed as it does not
consider the existance of options. Also, it passes entire argv to run_test(),
even though option args should be ommitted. 

All fixes are done on smbtorture in Samba 4.
Comment 1 Shiro Yamada 2003-12-26 02:12:39 UTC
Created attachment 340 [details]
a proposed patch for this bug
Comment 2 Volker Lendecke 2003-12-30 07:22:54 UTC
Fixed in 3_0 CVS. Named the variable 'found' and not 'notfound'.
Comment 3 Shiro Yamada 2004-01-04 18:11:18 UTC
Would you fix 'testsuite/build_farm/torture-RW2.test' as well, where
   test_torture "RW22"
should be
   test_torture "RW2"
Comment 4 Tim Potter 2004-01-04 18:59:37 UTC
Comment 5 Gerald (Jerry) Carter 2005-08-24 10:18:46 UTC
sorry for the same, cleaning up the database to prevent unecessary reopens of bugs.