Bug 9239 - samba-tool domain provision do not set ACLs on sysvol folders
Summary: samba-tool domain provision do not set ACLs on sysvol folders
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.0
Classification: Unclassified
Component: Tools (show other bugs)
Version: 4.0.0rc1
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Matthieu Patou
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-03 06:45 UTC by Matthieu Patou
Modified: 2013-01-10 12:27 UTC (History)
0 users

See Also:

Attachments
Proposed patch to fix the problem (2.39 KB, patch)
2012-10-03 06:45 UTC, Matthieu Patou 		abartlet: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthieu Patou 2012-10-03 06:45:29 UTC 
Created attachment 7982 [details]
Proposed patch to fix the problem

The skip_sysvolacl parameter has False as a default value and in samba-tool domain provision this parameter is not overloaded which cause the domain creation to not set ACLs on sysvol folder and its childs.
Comment 1 Matthieu Patou 2012-10-03 06:46:12 UTC 
Patch is currently in autobuild.
Comment 2 Matthieu Patou 2012-10-14 21:06:58 UTC 
Karolin, please pick up for rc3.

Thanks
Comment 3 Karolin Seeger 2012-10-15 08:46:59 UTC 
Patch does not apply:

kseeger@bando:/data/git/samba/v4-0-test> git am 0001-s4-provision-do-not-skip-setting-the-acls-on-sysvol.patch
Applying: s4-provision: do not skip setting the acls on sysvol
error: patch failed: source4/scripting/python/samba/netcmd/domain.py:398
error: source4/scripting/python/samba/netcmd/domain.py: patch does not apply
error: patch failed: source4/scripting/python/samba/provision/__init__.py:1607
error: source4/scripting/python/samba/provision/__init__.py: patch does not apply
Patch failed at 0001 s4-provision: do not skip setting the acls on sysvol

Re-assigning to Matthieu.
Comment 4 Matthieu Patou 2012-10-16 22:17:21 UTC 
Strange, patch was applying at the moment I uploaded to bugzilla.
Comment 5 Matthieu Patou 2012-10-17 03:59:18 UTC 
It seems that this patch was already in v-4.0-stable:
commit 54dfa75b3e241fdc00041fb65b110da7d2c192ce
Author: Matthieu Patou <mat@matws.net>
Date:   Tue Oct 2 14:30:25 2012 -0700

    s4-provision: do not skip setting the acls on sysvol
    
    Autobuild-User(master): Matthieu Patou <mat@samba.org>
    Autobuild-Date(master): Wed Oct  3 10:26:06 CEST 2012 on sn-devel-104
    (cherry picked from commit c1677e3b2fe42de309459fd8f8b3bea48bca5055)

I must confess I don't understand how it has landed from master to v4.0-stable.

Karolin any idea ?

In anycase the bug is solved