The Samba-Bugzilla – Bug 9239
samba-tool domain provision do not set ACLs on sysvol folders
Last modified: 2013-01-10 12:27:51 UTC
Created attachment 7982 [details]
Proposed patch to fix the problem
The skip_sysvolacl parameter has False as a default value and in samba-tool domain provision this parameter is not overloaded which cause the domain creation to not set ACLs on sysvol folder and its childs.
Patch is currently in autobuild.
Karolin, please pick up for rc3.
Patch does not apply:
kseeger@bando:/data/git/samba/v4-0-test> git am 0001-s4-provision-do-not-skip-setting-the-acls-on-sysvol.patch
Applying: s4-provision: do not skip setting the acls on sysvol
error: patch failed: source4/scripting/python/samba/netcmd/domain.py:398
error: source4/scripting/python/samba/netcmd/domain.py: patch does not apply
error: patch failed: source4/scripting/python/samba/provision/__init__.py:1607
error: source4/scripting/python/samba/provision/__init__.py: patch does not apply
Patch failed at 0001 s4-provision: do not skip setting the acls on sysvol
Re-assigning to Matthieu.
Strange, patch was applying at the moment I uploaded to bugzilla.
It seems that this patch was already in v-4.0-stable:
Author: Matthieu Patou <email@example.com>
Date: Tue Oct 2 14:30:25 2012 -0700
s4-provision: do not skip setting the acls on sysvol
Autobuild-User(master): Matthieu Patou <firstname.lastname@example.org>
Autobuild-Date(master): Wed Oct 3 10:26:06 CEST 2012 on sn-devel-104
(cherry picked from commit c1677e3b2fe42de309459fd8f8b3bea48bca5055)
I must confess I don't understand how it has landed from master to v4.0-stable.
Karolin any idea ?
In anycase the bug is solved